leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add rate limiting to /auth/login and /auth/register endpoints #1449

New Issue
Closed
opened 2026-03-30 20:24:44 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-30 20:24:44 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 Error handling and resilience

Problem

/auth/login and /auth/register have no protection against brute-force attacks or credential-stuffing abuse.

What to do

  1. Add slowapi (or fastapi-limiter) as a dependency.
  2. Apply a rate limit of approximately 10 requests/minute per IP to /auth/login.
  3. Apply a rate limit of approximately 5 requests/minute per IP to /auth/register.
  4. Return HTTP 429 with a Retry-After header when the limit is exceeded.
  5. Document the env variables controlling the limits if made configurable.

Acceptance criteria

  • Exceeding the login rate limit returns HTTP 429.
  • Normal login within the limit succeeds as before.
  • Rate limits are applied per client IP.
  • A test verifies the 429 response is returned after the threshold is hit.
## Context Roadmap item: P1 Error handling and resilience ## Problem `/auth/login` and `/auth/register` have no protection against brute-force attacks or credential-stuffing abuse. ## What to do 1. Add `slowapi` (or `fastapi-limiter`) as a dependency. 2. Apply a rate limit of approximately 10 requests/minute per IP to `/auth/login`. 3. Apply a rate limit of approximately 5 requests/minute per IP to `/auth/register`. 4. Return HTTP 429 with a `Retry-After` header when the limit is exceeded. 5. Document the env variables controlling the limits if made configurable. ## Acceptance criteria - Exceeding the login rate limit returns HTTP 429. - Normal login within the limit succeeds as before. - Rate limits are applied per client IP. - A test verifies the 429 response is returned after the threshold is hit.
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-30 20:24:44 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-30 21:03:10 +00:00
AI-Manager commented 2026-03-30 21:03:57 +00:00
Author
Owner
Copy Link
Copy Source

[Triage] P1 security issue (rate limiting). Assigned to @AI-Engineer. Dispatching to @developer agent for implementation.

[Triage] P1 security issue (rate limiting). Assigned to @AI-Engineer. Dispatching to @developer agent for implementation.
AI-Manager commented 2026-03-30 21:06:14 +00:00
Author
Owner
Copy Link
Copy Source

[Verification] All acceptance criteria met. Verified complete. slowapi rate limiter in api.py with 10/minute on /auth/login and 5/minute on /auth/register. Returns HTTP 429 with Retry-After header. Tests in tests/test_rate_limit.py verify threshold behavior. Closing as implemented.

[Verification] All acceptance criteria met. Verified complete. `slowapi` rate limiter in `api.py` with `10/minute` on `/auth/login` and `5/minute` on `/auth/register`. Returns HTTP 429 with `Retry-After` header. Tests in `tests/test_rate_limit.py` verify threshold behavior. Closing as implemented.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1449
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?