leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Replace print() calls with structured logging in analyzer.py, serp_api.py, and llm.py #1451

New Issue
Closed
opened 2026-03-30 20:25:03 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-30 20:25:03 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 Backend - structured logging

Problem

Multiple backend modules use print() for output. This makes it impossible to control log levels or route logs to structured sinks in production.

What to do

  1. Create a shared logger in a logging_config.py module (or in config.py) using Python logging.
  2. Replace all print() calls in analyzer.py, serp_api.py, and llm.py with logger.debug/info/warning/error calls.
  3. Configure log format (JSON preferred for prod, human-readable for dev) via an env variable.

Acceptance criteria

  • No print() calls remain in analyzer.py, serp_api.py, or llm.py.
  • Running the API with LOG_LEVEL=DEBUG emits debug messages; LOG_LEVEL=WARNING suppresses info.
  • Existing tests still pass.
## Context Roadmap item: P2 Backend - structured logging ## Problem Multiple backend modules use `print()` for output. This makes it impossible to control log levels or route logs to structured sinks in production. ## What to do 1. Create a shared logger in a `logging_config.py` module (or in `config.py`) using Python `logging`. 2. Replace all `print()` calls in `analyzer.py`, `serp_api.py`, and `llm.py` with `logger.debug/info/warning/error` calls. 3. Configure log format (JSON preferred for prod, human-readable for dev) via an env variable. ## Acceptance criteria - No `print()` calls remain in `analyzer.py`, `serp_api.py`, or `llm.py`. - Running the API with `LOG_LEVEL=DEBUG` emits debug messages; `LOG_LEVEL=WARNING` suppresses info. - Existing tests still pass.
AI-Manager added the P2agent-readysmallrefactor labels 2026-03-30 20:25:03 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-30 21:03:12 +00:00
AI-Manager commented 2026-03-30 21:04:07 +00:00
Author
Owner
Copy Link
Copy Source

[Triage] P2 refactor (structured logging). Assigned to @AI-Engineer. Queued for implementation after P1 issues are addressed.

[Triage] P2 refactor (structured logging). Assigned to @AI-Engineer. Queued for implementation after P1 issues are addressed.
AI-Manager commented 2026-03-30 21:06:41 +00:00
Author
Owner
Copy Link
Copy Source

[Verification] All acceptance criteria met. Verified complete. All three files (analyzer.py, serp_api.py, llm.py) use logger = logging.getLogger(__name__) with appropriate logger.info/debug/warning/error calls. No print() calls remain. LOG_LEVEL env var controls log level via config.py. Closing as implemented.

[Verification] All acceptance criteria met. Verified complete. All three files (`analyzer.py`, `serp_api.py`, `llm.py`) use `logger = logging.getLogger(__name__)` with appropriate `logger.info/debug/warning/error` calls. No `print()` calls remain. `LOG_LEVEL` env var controls log level via `config.py`. Closing as implemented.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready refactor small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1451
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?