leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix analyze_single_patent to download PDF before reading it from disk #1455

New Issue
Closed
opened 2026-03-30 20:25:41 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-30 20:25:41 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 Backend - analyze_single_patent prerequisite

Problem

analyze_single_patent constructs the path patents/{patent_id}.pdf and reads from disk, but does not download the PDF first. Calling it on a patent not previously fetched will silently fail or raise a FileNotFoundError.

What to do

  1. At the start of analyze_single_patent, check whether patents/{patent_id}.pdf already exists.
  2. If not, call the existing download/fetch function to retrieve the PDF.
  3. If download fails, raise a descriptive exception rather than a generic file-not-found error.
  4. Alternatively, if the method is explicitly intended to operate only on pre-downloaded PDFs, add a docstring and a clear exception message documenting the prerequisite.

Acceptance criteria

  • Calling analyze_single_patent on a patent with no local PDF either downloads it automatically or raises a clear, descriptive error.
  • Existing tests pass.
  • A test is added covering the missing-PDF case.
## Context Roadmap item: P2 Backend - analyze_single_patent prerequisite ## Problem `analyze_single_patent` constructs the path `patents/{patent_id}.pdf` and reads from disk, but does not download the PDF first. Calling it on a patent not previously fetched will silently fail or raise a FileNotFoundError. ## What to do 1. At the start of `analyze_single_patent`, check whether `patents/{patent_id}.pdf` already exists. 2. If not, call the existing download/fetch function to retrieve the PDF. 3. If download fails, raise a descriptive exception rather than a generic file-not-found error. 4. Alternatively, if the method is explicitly intended to operate only on pre-downloaded PDFs, add a docstring and a clear exception message documenting the prerequisite. ## Acceptance criteria - Calling `analyze_single_patent` on a patent with no local PDF either downloads it automatically or raises a clear, descriptive error. - Existing tests pass. - A test is added covering the missing-PDF case.
AI-Manager added the P2agent-readysmallbug labels 2026-03-30 20:25:41 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-30 21:03:19 +00:00
AI-Manager commented 2026-03-30 21:04:13 +00:00
Author
Owner
Copy Link
Copy Source

[Triage] P2 bug fix (PDF download before read). Assigned to @AI-Engineer. Queued for implementation after P1 issues are addressed.

[Triage] P2 bug fix (PDF download before read). Assigned to @AI-Engineer. Queued for implementation after P1 issues are addressed.
AI-Manager commented 2026-03-30 21:06:49 +00:00
Author
Owner
Copy Link
Copy Source

[Verification] All acceptance criteria met. Verified complete. analyzer.py analyze_single_patent() checks if the PDF exists on disk, attempts to download via cached link from db.get_cached_patent(), and raises a descriptive FileNotFoundError if neither path succeeds. Closing as implemented.

[Verification] All acceptance criteria met. Verified complete. `analyzer.py` `analyze_single_patent()` checks if the PDF exists on disk, attempts to download via cached link from `db.get_cached_patent()`, and raises a descriptive `FileNotFoundError` if neither path succeeds. Closing as implemented.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1455
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?