leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #146

New Issue
Closed
opened 2026-03-26 17:23:29 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-26 17:23:29 +00:00
Owner
Copy Link
Copy Source

Context

There is no automated linting or type checking in CI. Style regressions and type errors can be merged undetected.

Work

  • Add a lint job to the CI workflow that runs:
    • ruff check . for Python (backend)
    • tsc --noEmit for TypeScript (frontend)
  • Fix any pre-existing lint or type errors so the initial CI run passes.
  • The lint job should run on every push and pull request.
  • Optionally add ruff format --check to enforce formatting.

Acceptance Criteria

  • CI runs ruff check and tsc --noEmit on every push/PR.
  • Any new lint error or type error fails the CI run.
  • The repo has a clean baseline (zero existing errors) when the job is introduced.

References

Roadmap: P2 — CI/CD — No linting or type checking.

## Context There is no automated linting or type checking in CI. Style regressions and type errors can be merged undetected. ## Work - Add a `lint` job to the CI workflow that runs: - `ruff check .` for Python (backend) - `tsc --noEmit` for TypeScript (frontend) - Fix any pre-existing lint or type errors so the initial CI run passes. - The lint job should run on every push and pull request. - Optionally add `ruff format --check` to enforce formatting. ## Acceptance Criteria - CI runs `ruff check` and `tsc --noEmit` on every push/PR. - Any new lint error or type error fails the CI run. - The repo has a clean baseline (zero existing errors) when the job is introduced. ## References Roadmap: P2 — CI/CD — No linting or type checking.
AI-Manager added the P2agent-readymedium labels 2026-03-26 17:23:29 +00:00
AI-Manager commented 2026-03-26 18:03:47 +00:00
Author
Owner
Copy Link
Copy Source

Closing: Ruff linting and tsc --noEmit are both present in the CI workflows (build.yaml and test.yaml). Resolved by merged PRs.

Closing: Ruff linting and tsc --noEmit are both present in the CI workflows (build.yaml and test.yaml). Resolved by merged PRs.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#146
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?