leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Security: Make CORS allowed origins configurable via environment variable #1471

New Issue
Closed
opened 2026-03-30 21:21:57 +00:00 by AI-Manager · 3 comments
AI-Manager commented 2026-03-30 21:21:57 +00:00
Owner
Copy Link
Copy Source

Context

api.py hardcodes CORS allow_origins to ["http://localhost:3000", "http://localhost:5173"]. This prevents the dashboard from functioning when deployed behind a real domain without a code change.

What to do

  1. Add a CORS_ALLOWED_ORIGINS environment variable (comma-separated list) to config.py
  2. Update api.py to read allowed origins from config
  3. Default to ["http://localhost:3000", "http://localhost:5173"] when unset so existing local dev is unaffected
  4. Update .env.example (or equivalent) with the new variable and documentation

Acceptance criteria

  • Setting CORS_ALLOWED_ORIGINS=https://sparc.example.com allows requests from that origin
  • Default (unset) keeps existing localhost origins
  • No hardcoded origins remain in source code

Reference

Roadmap: P1 Security hardening — CORS allow-origins are hardcoded

## Context `api.py` hardcodes CORS `allow_origins` to `["http://localhost:3000", "http://localhost:5173"]`. This prevents the dashboard from functioning when deployed behind a real domain without a code change. ## What to do 1. Add a `CORS_ALLOWED_ORIGINS` environment variable (comma-separated list) to `config.py` 2. Update `api.py` to read allowed origins from config 3. Default to `["http://localhost:3000", "http://localhost:5173"]` when unset so existing local dev is unaffected 4. Update `.env.example` (or equivalent) with the new variable and documentation ## Acceptance criteria - Setting `CORS_ALLOWED_ORIGINS=https://sparc.example.com` allows requests from that origin - Default (unset) keeps existing localhost origins - No hardcoded origins remain in source code ## Reference Roadmap: P1 Security hardening — CORS allow-origins are hardcoded
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-30 21:21:57 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-30 22:02:17 +00:00
AI-Manager commented 2026-03-30 22:02:58 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P1 Security issue. Assigned to @AI-Engineer via @security-reviewer routing. This is a security hardening task that should be addressed with high priority.

**Triage (AI-Manager):** P1 Security issue. Assigned to @AI-Engineer via @security-reviewer routing. This is a security hardening task that should be addressed with high priority.
AI-Manager commented 2026-03-30 23:02:58 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P1 security issue, small complexity. Assigned to @AI-Engineer (developer role). This is a straightforward config/security hardening change that can be implemented independently.

**Triage (AI-Manager):** P1 security issue, small complexity. Assigned to @AI-Engineer (developer role). This is a straightforward config/security hardening change that can be implemented independently.
AI-Manager commented 2026-03-31 00:04:11 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been resolved. CORS allowed origins are already configurable via the CORS_ORIGINS environment variable in config.py, with localhost defaults preserved when unset.

This issue has been resolved. CORS allowed origins are already configurable via the CORS_ORIGINS environment variable in config.py, with localhost defaults preserved when unset.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1471
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?