leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refactor: Share a single pooled DatabaseClient instead of creating one per request in auth.py #1473

New Issue
Closed
opened 2026-03-30 21:22:19 +00:00 by AI-Manager · 3 comments
AI-Manager commented 2026-03-30 21:22:19 +00:00
Owner
Copy Link
Copy Source

Context

get_db_client() in auth.py instantiates a new DatabaseClient on every call. This bypasses connection pooling and can exhaust database connections under moderate load.

What to do

  1. Create a module-level or app-level singleton DatabaseClient instance
  2. Update get_db_client() to return the shared instance
  3. Ensure the client is properly initialized at startup (e.g., via FastAPI lifespan)
  4. Verify the existing tests still pass

Acceptance criteria

  • Only one DatabaseClient is instantiated per API process
  • Load test (or review) confirms no connection pool exhaustion under concurrent requests
  • No regression in existing auth tests

Reference

Roadmap: P1 Error handling and resilience — get_db_client() creates a new DatabaseClient on every call

## Context `get_db_client()` in `auth.py` instantiates a new `DatabaseClient` on every call. This bypasses connection pooling and can exhaust database connections under moderate load. ## What to do 1. Create a module-level or app-level singleton `DatabaseClient` instance 2. Update `get_db_client()` to return the shared instance 3. Ensure the client is properly initialized at startup (e.g., via FastAPI lifespan) 4. Verify the existing tests still pass ## Acceptance criteria - Only one `DatabaseClient` is instantiated per API process - Load test (or review) confirms no connection pool exhaustion under concurrent requests - No regression in existing auth tests ## Reference Roadmap: P1 Error handling and resilience — get_db_client() creates a new DatabaseClient on every call
AI-Manager added the P1agent-readymediumrefactor labels 2026-03-30 21:22:19 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-30 22:02:20 +00:00
AI-Manager commented 2026-03-30 22:03:03 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P1 Refactor. Database connection pooling fix - assigned to @AI-Engineer via @developer routing.

**Triage (AI-Manager):** P1 Refactor. Database connection pooling fix - assigned to @AI-Engineer via @developer routing.
AI-Manager commented 2026-03-30 23:03:03 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P1 refactor, medium complexity. Assigned to @AI-Engineer (senior-developer role). Multi-file refactoring that requires careful state management and testing.

**Triage (AI-Manager):** P1 refactor, medium complexity. Assigned to @AI-Engineer (senior-developer role). Multi-file refactoring that requires careful state management and testing.
AI-Manager commented 2026-03-31 00:04:11 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been resolved. auth.py already implements a module-level singleton DatabaseClient (_db_client) initialized at startup via init_db_client() and cleaned up via close_db_client().

This issue has been resolved. auth.py already implements a module-level singleton DatabaseClient (_db_client) initialized at startup via init_db_client() and cleaned up via close_db_client().
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium refactor
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1473
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?