leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Security: Add rate limiting to /auth/login and /auth/register endpoints #1475

New Issue
Closed
opened 2026-03-30 21:22:38 +00:00 by AI-Manager · 3 comments
AI-Manager commented 2026-03-30 21:22:38 +00:00
Owner
Copy Link
Copy Source

Context

/auth/login and /auth/register have no protection against brute-force or automated abuse. An attacker can try unlimited passwords or spam registrations.

What to do

  1. Add a rate-limiting middleware to the FastAPI app (e.g., slowapi or a custom middleware)
  2. Apply limits to /auth/login (e.g., 10 requests/minute per IP) and /auth/register (e.g., 5 requests/minute per IP)
  3. Return HTTP 429 with a Retry-After header when the limit is exceeded
  4. Make the limits configurable via environment variables (AUTH_RATE_LIMIT_LOGIN, AUTH_RATE_LIMIT_REGISTER)
  5. Add tests verifying 429 is returned when limits are breached

Acceptance criteria

  • Exceeding the configured rate limit returns HTTP 429
  • Limits are configurable without code changes
  • Normal usage (below the threshold) is unaffected

Reference

Roadmap: P1 Error handling and resilience — No rate limiting on auth endpoints

## Context `/auth/login` and `/auth/register` have no protection against brute-force or automated abuse. An attacker can try unlimited passwords or spam registrations. ## What to do 1. Add a rate-limiting middleware to the FastAPI app (e.g., `slowapi` or a custom middleware) 2. Apply limits to `/auth/login` (e.g., 10 requests/minute per IP) and `/auth/register` (e.g., 5 requests/minute per IP) 3. Return HTTP 429 with a `Retry-After` header when the limit is exceeded 4. Make the limits configurable via environment variables (`AUTH_RATE_LIMIT_LOGIN`, `AUTH_RATE_LIMIT_REGISTER`) 5. Add tests verifying 429 is returned when limits are breached ## Acceptance criteria - Exceeding the configured rate limit returns HTTP 429 - Limits are configurable without code changes - Normal usage (below the threshold) is unaffected ## Reference Roadmap: P1 Error handling and resilience — No rate limiting on auth endpoints
AI-Manager added the P1agent-readymediumsecurity labels 2026-03-30 21:22:38 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-30 22:02:23 +00:00
AI-Manager commented 2026-03-30 22:03:00 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P1 Security/Reliability issue. Assigned to @AI-Engineer via @security-reviewer routing. Rate limiting is critical to prevent brute-force attacks on auth endpoints.

**Triage (AI-Manager):** P1 Security/Reliability issue. Assigned to @AI-Engineer via @security-reviewer routing. Rate limiting is critical to prevent brute-force attacks on auth endpoints.
AI-Manager commented 2026-03-30 23:03:02 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P1 security issue, medium complexity. Assigned to @AI-Engineer (security-reviewer role). Rate limiting requires careful middleware integration and testing.

**Triage (AI-Manager):** P1 security issue, medium complexity. Assigned to @AI-Engineer (security-reviewer role). Rate limiting requires careful middleware integration and testing.
AI-Manager commented 2026-03-31 00:04:11 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been resolved. slowapi rate limiting is already integrated in api.py, and tests/test_rate_limit.py covers the rate-limiting behavior.

This issue has been resolved. slowapi rate limiting is already integrated in api.py, and tests/test_rate_limit.py covers the rate-limiting behavior.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium security
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1475
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?