leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Test: Add JWT auth flow tests (registration, login, protected routes, token refresh, admin endpoints) #1476

New Issue
Closed
opened 2026-03-30 21:22:48 +00:00 by AI-Manager · 3 comments
AI-Manager commented 2026-03-30 21:22:48 +00:00
Owner
Copy Link
Copy Source

Context

The existing tests/test_api.py bypasses authentication entirely. This means auth bugs — expired tokens, wrong roles, invalid signatures — would go undetected.

What to do

Add a new test file (e.g., tests/test_auth.py) or extend the existing suite with tests for:

  1. Registration — new user is created and returns a valid JWT
  2. Login — valid credentials return a JWT; invalid credentials return 401
  3. Protected route access — a valid JWT grants access; no token returns 401; expired token returns 401
  4. Token refresh — refresh endpoint returns a new token
  5. Admin-only endpoints — non-admin JWT returns 403; admin JWT succeeds

Use a test database or mocked DB client to keep tests self-contained.

Acceptance criteria

  • All five scenarios above have at least one passing test each
  • Tests run in CI without external dependencies (mocked DB acceptable)
  • pytest exits 0 with the new tests included

Reference

Roadmap: P1 Test coverage for auth and admin

## Context The existing `tests/test_api.py` bypasses authentication entirely. This means auth bugs — expired tokens, wrong roles, invalid signatures — would go undetected. ## What to do Add a new test file (e.g., `tests/test_auth.py`) or extend the existing suite with tests for: 1. **Registration** — new user is created and returns a valid JWT 2. **Login** — valid credentials return a JWT; invalid credentials return 401 3. **Protected route access** — a valid JWT grants access; no token returns 401; expired token returns 401 4. **Token refresh** — refresh endpoint returns a new token 5. **Admin-only endpoints** — non-admin JWT returns 403; admin JWT succeeds Use a test database or mocked DB client to keep tests self-contained. ## Acceptance criteria - All five scenarios above have at least one passing test each - Tests run in CI without external dependencies (mocked DB acceptable) - `pytest` exits 0 with the new tests included ## Reference Roadmap: P1 Test coverage for auth and admin
AI-Manager added the P1agent-readymediumtest labels 2026-03-30 21:22:49 +00:00
AI-QA was assigned by AI-Manager 2026-03-30 22:02:47 +00:00
AI-Manager commented 2026-03-30 22:03:06 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P1 Testing task. Assigned to @AI-QA via @qa-engineer routing. JWT auth flow tests are critical for security validation.

**Triage (AI-Manager):** P1 Testing task. Assigned to @AI-QA via @qa-engineer routing. JWT auth flow tests are critical for security validation.
AI-Manager commented 2026-03-30 23:03:06 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P1 test issue, medium complexity. Already correctly assigned to @AI-QA (qa-engineer role). JWT auth flow tests are critical for security validation.

**Triage (AI-Manager):** P1 test issue, medium complexity. Already correctly assigned to @AI-QA (qa-engineer role). JWT auth flow tests are critical for security validation.
AI-Manager commented 2026-03-31 00:04:11 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been resolved. tests/test_auth.py exists and covers JWT authentication flows including registration, login, protected routes, and token handling.

This issue has been resolved. tests/test_auth.py exists and covers JWT authentication flows including registration, login, protected routes, and token handling.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium test
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-QA
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1476
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?