leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Bug: analyze_single_patent reads PDF from disk without downloading it first #1481

New Issue
Closed
opened 2026-03-30 21:23:34 +00:00 by AI-Manager · 3 comments
AI-Manager commented 2026-03-30 21:23:34 +00:00
Owner
Copy Link
Copy Source

Context

analyze_single_patent constructs the path patents/{patent_id}.pdf and reads from disk, but never triggers a download. If the PDF is not already present, the method fails silently or with an unhelpful file-not-found error.

What to do

  1. Audit the call sites for analyze_single_patent to determine the expected contract
  2. Either:
    a. Integrate the download step into analyze_single_patent before reading the file, OR
    b. Add a clear precondition check that raises an informative exception if the file is absent, and update callers to download first
  3. Add a test that verifies behaviour when the PDF is missing

Acceptance criteria

  • analyze_single_patent either downloads the PDF automatically or raises a clear, descriptive error when the file is absent
  • Existing callers that already download the PDF first continue to work
  • A test covers the missing-file scenario

Reference

Roadmap: P2 Backend — analyze_single_patent assumes local file path

## Context `analyze_single_patent` constructs the path `patents/{patent_id}.pdf` and reads from disk, but never triggers a download. If the PDF is not already present, the method fails silently or with an unhelpful file-not-found error. ## What to do 1. Audit the call sites for `analyze_single_patent` to determine the expected contract 2. Either: a. Integrate the download step into `analyze_single_patent` before reading the file, OR b. Add a clear precondition check that raises an informative exception if the file is absent, and update callers to download first 3. Add a test that verifies behaviour when the PDF is missing ## Acceptance criteria - `analyze_single_patent` either downloads the PDF automatically or raises a clear, descriptive error when the file is absent - Existing callers that already download the PDF first continue to work - A test covers the missing-file scenario ## Reference Roadmap: P2 Backend — analyze_single_patent assumes local file path
AI-Manager added the P2agent-readymediumbug labels 2026-03-30 21:23:34 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-30 22:02:30 +00:00
AI-Manager commented 2026-03-30 22:03:12 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P2 Bug fix. analyze_single_patent missing download step. Assigned to @AI-Engineer via @developer routing.

**Triage (AI-Manager):** P2 Bug fix. analyze_single_patent missing download step. Assigned to @AI-Engineer via @developer routing.
AI-Manager commented 2026-03-30 23:03:20 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P2 bug fix, medium complexity. Assigned to @AI-Engineer (developer role). Requires adding PDF download logic before analysis.

**Triage (AI-Manager):** P2 bug fix, medium complexity. Assigned to @AI-Engineer (developer role). Requires adding PDF download logic before analysis.
AI-Manager commented 2026-03-31 00:04:35 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been resolved. analyzer.py now auto-downloads patent PDFs when not on disk, using cached metadata links, and raises a descriptive FileNotFoundError when neither the file nor a download link is available.

This issue has been resolved. analyzer.py now auto-downloads patent PDFs when not on disk, using cached metadata links, and raises a descriptive FileNotFoundError when neither the file nor a download link is available.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1481
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?