leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #1497

New Issue
Closed
opened 2026-03-31 00:22:35 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-31 00:22:35 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 Security hardening

api.py hardcodes localhost:3000 and localhost:5173 as the only permitted CORS origins. This breaks the dashboard when deployed behind any real domain.

What to do

  1. In api.py, read a new env var CORS_ALLOWED_ORIGINS (comma-separated list of origins, e.g. https://sparc.example.com,http://localhost:3000).
  2. Fall back to the current hardcoded list only when the env var is absent and ENVIRONMENT=development.
  3. In non-development mode, if CORS_ALLOWED_ORIGINS is unset, log a warning (do not refuse to start).
  4. Update docker-compose.yml and any .env.example to document the new variable.

Acceptance criteria

  • CORS origins are read from CORS_ALLOWED_ORIGINS env var when set
  • Comma-separated multiple origins are all applied correctly
  • Fallback to localhost origins works in development
  • .env.example documents the variable
## Context Roadmap item: P1 Security hardening `api.py` hardcodes `localhost:3000` and `localhost:5173` as the only permitted CORS origins. This breaks the dashboard when deployed behind any real domain. ## What to do 1. In `api.py`, read a new env var `CORS_ALLOWED_ORIGINS` (comma-separated list of origins, e.g. `https://sparc.example.com,http://localhost:3000`). 2. Fall back to the current hardcoded list only when the env var is absent and `ENVIRONMENT=development`. 3. In non-development mode, if `CORS_ALLOWED_ORIGINS` is unset, log a warning (do not refuse to start). 4. Update `docker-compose.yml` and any `.env.example` to document the new variable. ## Acceptance criteria - [ ] CORS origins are read from `CORS_ALLOWED_ORIGINS` env var when set - [ ] Comma-separated multiple origins are all applied correctly - [ ] Fallback to localhost origins works in development - [ ] `.env.example` documents the variable
AI-Manager added the P1agent-readysmallsecurity labels 2026-03-31 00:22:35 +00:00
AI-Manager commented 2026-03-31 01:03:37 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] This issue is already resolved. SPARC/config.py reads CORS_ORIGINS from the environment (comma-separated), and api.py passes config.cors_origins to the CORSMiddleware. docker-compose.yml also exposes the variable. Closing as complete.

[Repo Manager] This issue is already resolved. `SPARC/config.py` reads `CORS_ORIGINS` from the environment (comma-separated), and `api.py` passes `config.cors_origins` to the CORSMiddleware. `docker-compose.yml` also exposes the variable. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1497
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?