leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Replace print() calls with structured Python logging in analyzer.py, serp_api.py, and llm.py #1503

New Issue
Closed
opened 2026-03-31 00:23:34 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-31 00:23:34 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 Backend — structured logging

analyzer.py, serp_api.py, and llm.py use print() for diagnostic output. This bypasses Python's logging framework, making it impossible to control log levels, filter output, or integrate with log aggregators.

What to do

  1. Add import logging and logger = logging.getLogger(__name__) at the top of each affected module.
  2. Replace each print() call with the appropriate log level: logger.debug() for verbose trace output, logger.info() for normal flow events, logger.warning() for recoverable issues, logger.error() for failures.
  3. Configure the root logger in api.py or a dedicated logging_config.py (level from LOG_LEVEL env var, default INFO).
  4. Verify that docker compose up still shows meaningful log output.

Acceptance criteria

  • No print() calls remain in analyzer.py, serp_api.py, or llm.py
  • Log level is controlled by LOG_LEVEL environment variable
  • Log output includes module name and level
  • Existing tests still pass
## Context Roadmap item: P2 Backend — structured logging `analyzer.py`, `serp_api.py`, and `llm.py` use `print()` for diagnostic output. This bypasses Python's logging framework, making it impossible to control log levels, filter output, or integrate with log aggregators. ## What to do 1. Add `import logging` and `logger = logging.getLogger(__name__)` at the top of each affected module. 2. Replace each `print()` call with the appropriate log level: `logger.debug()` for verbose trace output, `logger.info()` for normal flow events, `logger.warning()` for recoverable issues, `logger.error()` for failures. 3. Configure the root logger in `api.py` or a dedicated `logging_config.py` (level from `LOG_LEVEL` env var, default `INFO`). 4. Verify that `docker compose up` still shows meaningful log output. ## Acceptance criteria - [ ] No `print()` calls remain in `analyzer.py`, `serp_api.py`, or `llm.py` - [ ] Log level is controlled by `LOG_LEVEL` environment variable - [ ] Log output includes module name and level - [ ] Existing tests still pass
AI-Manager added the P2agent-readysmallrefactor labels 2026-03-31 00:23:34 +00:00
AI-Manager commented 2026-03-31 01:03:50 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] This issue is already resolved. All Python modules (analyzer.py, serp_api.py, llm.py, webhooks.py, scheduler.py) use logging.getLogger(__name__) and the logger instance. No print() calls remain in the SPARC package. Closing as complete.

[Repo Manager] This issue is already resolved. All Python modules (`analyzer.py`, `serp_api.py`, `llm.py`, `webhooks.py`, `scheduler.py`) use `logging.getLogger(__name__)` and the `logger` instance. No `print()` calls remain in the SPARC package. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready refactor small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1503
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?