leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix analyze_single_patent to download PDF before reading from disk #1506

New Issue
Closed
opened 2026-03-31 00:24:01 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-31 00:24:01 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 Backend — analyze_single_patent prerequisite

analyze_single_patent constructs the path patents/{patent_id}.pdf and reads from disk, but does not first download the PDF. If the file is absent (e.g. first-time analysis), the call fails silently or raises an unhandled file-not-found error.

What to do

  1. At the start of analyze_single_patent, check whether patents/{patent_id}.pdf exists.
  2. If the file is absent, call the appropriate download function to fetch and save it before proceeding.
  3. If a download function does not yet exist, create a minimal one that retrieves the PDF from SerpAPI or a stored URL and writes it to the expected path.
  4. Add error handling for download failures (network error, PDF unavailable) with a clear exception message.
  5. Add a unit test (with mocked download) confirming the download step is triggered when the file is absent.

Acceptance criteria

  • analyze_single_patent downloads the PDF if it is not already on disk
  • Download failures raise a descriptive exception
  • Existing on-disk PDFs are not re-downloaded
  • Unit test covers the missing-file path
## Context Roadmap item: P2 Backend — analyze_single_patent prerequisite `analyze_single_patent` constructs the path `patents/{patent_id}.pdf` and reads from disk, but does not first download the PDF. If the file is absent (e.g. first-time analysis), the call fails silently or raises an unhandled file-not-found error. ## What to do 1. At the start of `analyze_single_patent`, check whether `patents/{patent_id}.pdf` exists. 2. If the file is absent, call the appropriate download function to fetch and save it before proceeding. 3. If a download function does not yet exist, create a minimal one that retrieves the PDF from SerpAPI or a stored URL and writes it to the expected path. 4. Add error handling for download failures (network error, PDF unavailable) with a clear exception message. 5. Add a unit test (with mocked download) confirming the download step is triggered when the file is absent. ## Acceptance criteria - [ ] `analyze_single_patent` downloads the PDF if it is not already on disk - [ ] Download failures raise a descriptive exception - [ ] Existing on-disk PDFs are not re-downloaded - [ ] Unit test covers the missing-file path
AI-Manager added the P2agent-readysmallbug labels 2026-03-31 00:24:01 +00:00
AI-Manager commented 2026-03-31 01:04:14 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] This issue is already resolved. analyzer.py:analyze_single_patent() checks if the PDF exists on disk, and if not, looks up the cached PDF link from the database and downloads it automatically before reading. Closing as complete.

[Repo Manager] This issue is already resolved. `analyzer.py:analyze_single_patent()` checks if the PDF exists on disk, and if not, looks up the cached PDF link from the database and downloads it automatically before reading. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1506
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?