forked from 0xWheatyz/SPARC
Add frontend lockfile (package-lock.json or pnpm-lock.yaml) to repository #1509
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Context
Roadmap item: P2 Frontend — lockfile
The frontend directory has no committed lockfile. Without one,
npm install/pnpm installresolves different package versions on different machines and CI runs, making builds non-reproducible.What to do
npm install(orpnpm installif pnpm is the intended package manager) to generate a lockfile.package-lock.json(orpnpm-lock.yaml) to the repository..gitignoreto ensure the lockfile is NOT ignored.docker-compose.ymlfrontend build step (if applicable) to usenpm ciinstead ofnpm installfor reproducible installs.npm ci).Acceptance criteria
package.json.gitignoredoes not exclude the lockfilenpm ci(or equivalent) for reproducible installs[Repo Manager] This issue is already resolved.
frontend/package-lock.jsonexists in the repository. CI workflows usenpm ciwhich relies on it. Closing as complete.