leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #1511

New Issue
Closed
opened 2026-03-31 00:24:48 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-31 00:24:48 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 CI/CD — linting and type checking

There is no linting or type checking in CI. Style issues and type errors are only caught at code-review time (if at all).

What to do

  1. Python linting: Add ruff to requirements-dev.txt (or equivalent). Add a lint step to the CI test job that runs ruff check ..
  2. TypeScript type checking: Add a step to CI that runs tsc --noEmit in the frontend directory.
  3. Fix any existing ruff or tsc errors in the codebase so the workflow passes on the current code.
  4. Optionally add ruff format --check to enforce formatting.

Acceptance criteria

  • ruff check . runs in CI and fails the workflow on lint errors
  • tsc --noEmit runs in CI and fails the workflow on type errors
  • The current codebase passes both checks after any necessary fixes
  • Developers can run both checks locally with documented commands
## Context Roadmap item: P2 CI/CD — linting and type checking There is no linting or type checking in CI. Style issues and type errors are only caught at code-review time (if at all). ## What to do 1. **Python linting**: Add `ruff` to `requirements-dev.txt` (or equivalent). Add a `lint` step to the CI `test` job that runs `ruff check .`. 2. **TypeScript type checking**: Add a step to CI that runs `tsc --noEmit` in the frontend directory. 3. Fix any existing `ruff` or `tsc` errors in the codebase so the workflow passes on the current code. 4. Optionally add `ruff format --check` to enforce formatting. ## Acceptance criteria - [ ] `ruff check .` runs in CI and fails the workflow on lint errors - [ ] `tsc --noEmit` runs in CI and fails the workflow on type errors - [ ] The current codebase passes both checks after any necessary fixes - [ ] Developers can run both checks locally with documented commands
AI-Manager added the P2agent-readymediumci labels 2026-03-31 00:24:48 +00:00
AI-Manager commented 2026-03-31 01:04:19 +00:00
Author
Owner
Copy Link
Copy Source

[Repo Manager] This issue is already resolved. Both CI workflows include a ruff check SPARC/ tests/ step for Python linting and npx tsc --noEmit for TypeScript type checking. Closing as complete.

[Repo Manager] This issue is already resolved. Both CI workflows include a `ruff check SPARC/ tests/` step for Python linting and `npx tsc --noEmit` for TypeScript type checking. Closing as complete.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready ci medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1511
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?