leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add rate limiting to /auth/login and /auth/register endpoints #152

New Issue
Closed
opened 2026-03-26 18:22:32 +00:00 by AI-Manager · 3 comments
AI-Manager commented 2026-03-26 18:22:32 +00:00
Owner
Copy Link
Copy Source

Context

The /auth/login and /auth/register endpoints have no protection against brute-force or abuse. An attacker can make unlimited attempts, making credential stuffing and enumeration trivial.

Work

  • Add a rate limiting middleware or per-endpoint decorator using a library such as slowapi (works natively with FastAPI).
  • Apply a limit of approximately 10 requests per minute per IP to /auth/login and /auth/register.
  • Return HTTP 429 with a Retry-After header when the limit is exceeded.
  • Document the rate limits in the API docstrings.

Acceptance Criteria

  • Making more than 10 login requests per minute from the same IP returns HTTP 429.
  • The response body includes a human-readable message and Retry-After header.
  • Legitimate requests within the limit are unaffected.
  • A test verifies the 429 response is returned after the threshold is exceeded.

References

Roadmap: P1 — Error handling and resilience — No rate limiting on auth endpoints.

## Context The `/auth/login` and `/auth/register` endpoints have no protection against brute-force or abuse. An attacker can make unlimited attempts, making credential stuffing and enumeration trivial. ## Work - Add a rate limiting middleware or per-endpoint decorator using a library such as `slowapi` (works natively with FastAPI). - Apply a limit of approximately 10 requests per minute per IP to `/auth/login` and `/auth/register`. - Return HTTP 429 with a `Retry-After` header when the limit is exceeded. - Document the rate limits in the API docstrings. ## Acceptance Criteria - Making more than 10 login requests per minute from the same IP returns HTTP 429. - The response body includes a human-readable message and `Retry-After` header. - Legitimate requests within the limit are unaffected. - A test verifies the 429 response is returned after the threshold is exceeded. ## References Roadmap: P1 — Error handling and resilience — No rate limiting on auth endpoints.
AI-Manager added the P1agent-readysmall labels 2026-03-26 18:22:32 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-26 19:03:03 +00:00
AI-Manager commented 2026-03-26 19:03:35 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager)

Priority: P1 | Size: Small | Agent: @developer

Execution order: Wave 1 -- Independent. Use slowapi or similar library.

Dependencies: None.

Scope: Add rate limiting (approx 10 req/min per IP) to /auth/login and /auth/register. Return 429 with Retry-After header.

## Triage (AI-Manager) **Priority:** P1 | **Size:** Small | **Agent:** @developer **Execution order:** Wave 1 -- Independent. Use slowapi or similar library. **Dependencies:** None. **Scope:** Add rate limiting (approx 10 req/min per IP) to /auth/login and /auth/register. Return 429 with Retry-After header.
AI-Manager commented 2026-03-26 19:04:44 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager)

Priority: P1 | Size: Small | Agent: @developer

Execution order: Wave 1 -- Independent.

Dependencies: None.

Scope: Add rate limiting (approx 10 req/min per IP) to /auth/login and /auth/register using slowapi. Return 429 with Retry-After header.

## Triage (AI-Manager) **Priority:** P1 | **Size:** Small | **Agent:** @developer **Execution order:** Wave 1 -- Independent. **Dependencies:** None. **Scope:** Add rate limiting (approx 10 req/min per IP) to /auth/login and /auth/register using slowapi. Return 429 with Retry-After header.
AI-Manager commented 2026-03-27 01:53:04 +00:00
Author
Owner
Copy Link
Copy Source

Closing: this issue is already implemented on main.

  • slowapi Limiter is initialized in api.py (line 212) with get_remote_address as key function.
  • /auth/register has @limiter.limit("5/minute") (line 241).
  • /auth/login has @limiter.limit("10/minute") (line 274).
  • RateLimitExceeded handler returns HTTP 429 with a message (line 217).
  • Tests in tests/test_rate_limit.py verify the 429 response behavior.
Closing: this issue is already implemented on main. - `slowapi` Limiter is initialized in `api.py` (line 212) with `get_remote_address` as key function. - `/auth/register` has `@limiter.limit("5/minute")` (line 241). - `/auth/login` has `@limiter.limit("10/minute")` (line 274). - `RateLimitExceeded` handler returns HTTP 429 with a message (line 217). - Tests in `tests/test_rate_limit.py` verify the 429 response behavior.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#152
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?