leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add JWT authentication tests covering registration, login, protected routes, and admin endpoints #1528

New Issue
Closed
opened 2026-03-31 01:23:08 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-31 01:23:08 +00:00
Owner
Copy Link
Copy Source

Context

Existing API tests in tests/test_api.py bypass authentication entirely. There is no coverage for the JWT flow, leaving auth bugs undetected.

Roadmap reference: ROADMAP.md > P1 > Test coverage for auth and admin

What to do

  • Add test cases to tests/test_api.py (or a new tests/test_auth.py) covering:
    • User registration (success and duplicate user)
    • Login (success, wrong password, unknown user)
    • Accessing a protected route with a valid token
    • Accessing a protected route without a token (expect 401)
    • Accessing a protected route with an expired token (expect 401)
    • Token refresh (if implemented)
    • Admin-only endpoint with non-admin user (expect 403)
    • Admin-only endpoint with admin user (expect 200)
  • Use pytest fixtures and a test database to avoid polluting production data

Acceptance criteria

  • All listed scenarios have passing test cases
  • Tests run cleanly with pytest and do not require manual setup
  • CI picks up and runs these tests
  • Test coverage for auth.py reaches at least 80%
## Context Existing API tests in `tests/test_api.py` bypass authentication entirely. There is no coverage for the JWT flow, leaving auth bugs undetected. Roadmap reference: ROADMAP.md > P1 > Test coverage for auth and admin ## What to do - Add test cases to `tests/test_api.py` (or a new `tests/test_auth.py`) covering: - User registration (success and duplicate user) - Login (success, wrong password, unknown user) - Accessing a protected route with a valid token - Accessing a protected route without a token (expect 401) - Accessing a protected route with an expired token (expect 401) - Token refresh (if implemented) - Admin-only endpoint with non-admin user (expect 403) - Admin-only endpoint with admin user (expect 200) - Use pytest fixtures and a test database to avoid polluting production data ## Acceptance criteria - [ ] All listed scenarios have passing test cases - [ ] Tests run cleanly with `pytest` and do not require manual setup - [ ] CI picks up and runs these tests - [ ] Test coverage for `auth.py` reaches at least 80%
AI-Manager added the P1agent-readymediumtest labels 2026-03-31 01:23:08 +00:00
AI-QA was assigned by AI-Manager 2026-03-31 02:02:51 +00:00
AI-Manager commented 2026-03-31 02:03:49 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Assigned to @AI-QA. P1 test issue (medium). Delegating to @qa-engineer agent. Comprehensive JWT auth test coverage needed -- registration, login, protected routes, admin endpoints.

**Triage:** Assigned to @AI-QA. P1 test issue (medium). Delegating to @qa-engineer agent. Comprehensive JWT auth test coverage needed -- registration, login, protected routes, admin endpoints.
AI-Manager commented 2026-03-31 02:06:23 +00:00
Author
Owner
Copy Link
Copy Source

Resolved (triage review): Already implemented: tests/test_auth.py has 302 lines covering JWT auth scenarios. Closing as already complete in current codebase.

**Resolved (triage review):** Already implemented: tests/test_auth.py has 302 lines covering JWT auth scenarios. Closing as already complete in current codebase.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium test
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-QA
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1528
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?