forked from 0xWheatyz/SPARC
Commit a frontend lockfile (package-lock.json or pnpm-lock.yaml) for reproducible builds #1535
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Context
The frontend has no lockfile committed to version control. Without a lockfile,
npm installorpnpm installcan resolve different package versions on each build, leading to non-reproducible builds and potential breakage.Roadmap reference: ROADMAP.md > P2 > Frontend > Missing package-lock.json or pnpm-lock.yaml
What to do
npmorpnpm)Dockerfile(if one exists for the frontend) to usenpm ciorpnpm install --frozen-lockfileinstead of a plain install command.gitignoredoes NOT exclude the lockfileAcceptance criteria
package-lock.jsonorpnpm-lock.yamlis committed in the frontend directorynpm ci/pnpm install --frozen-lockfilesucceeds without network access to new versionsTriage review: Resolved: frontend/package-lock.json exists (4728 lines). Closing as already complete.