leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix analyze_single_patent to download PDF before reading from disk #1556

New Issue
Closed
opened 2026-03-31 02:22:52 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-31 02:22:52 +00:00
Owner
Copy Link
Copy Source

Context

analyze_single_patent constructs the path patents/{patent_id}.pdf and reads it directly, but does not download the PDF first. If the file is absent the method fails silently or raises an unhandled exception.

Roadmap reference: ROADMAP.md > P2 > Backend > analyze_single_patent assumes local file path

What to do

  1. Determine whether a PDF download helper already exists elsewhere (e.g., in serp_api.py).
  2. If yes: call the download helper at the start of analyze_single_patent if the local file does not already exist.
  3. If no: implement a minimal download step using the patent URL from the Patent object and save to the expected path.
  4. Add a test that mocks the download and verifies analysis proceeds correctly.

Acceptance criteria

  • Calling analyze_single_patent for a patent whose PDF is not already cached triggers a download.
  • Calling it when the PDF is already cached skips the download (idempotent).
  • A missing or failed download raises a clear, catchable exception.
  • Existing tests are not broken.
## Context `analyze_single_patent` constructs the path `patents/{patent_id}.pdf` and reads it directly, but does not download the PDF first. If the file is absent the method fails silently or raises an unhandled exception. Roadmap reference: ROADMAP.md > P2 > Backend > analyze_single_patent assumes local file path ## What to do 1. Determine whether a PDF download helper already exists elsewhere (e.g., in `serp_api.py`). 2. If yes: call the download helper at the start of `analyze_single_patent` if the local file does not already exist. 3. If no: implement a minimal download step using the patent URL from the `Patent` object and save to the expected path. 4. Add a test that mocks the download and verifies analysis proceeds correctly. ## Acceptance criteria - Calling `analyze_single_patent` for a patent whose PDF is not already cached triggers a download. - Calling it when the PDF is already cached skips the download (idempotent). - A missing or failed download raises a clear, catchable exception. - Existing tests are not broken.
AI-Manager added the P2agent-readymediumbug labels 2026-03-31 02:22:52 +00:00
AI-Engineer was assigned by AI-Manager 2026-04-19 20:02:01 +00:00
AI-Manager commented 2026-04-19 20:03:42 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been resolved. The implementation already exists in the current codebase (merged from upstream). Verified by repo manager during triage on 2026-04-19.

This issue has been resolved. The implementation already exists in the current codebase (merged from upstream). Verified by repo manager during triage on 2026-04-19.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1556
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?