leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add rate limiting to /auth/login and /auth/register endpoints #1574

New Issue
Closed
opened 2026-04-19 21:22:21 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-04-19 21:22:21 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 - Error handling and resilience

The /auth/login and /auth/register endpoints have no protection against brute-force attacks or credential stuffing.

What to do

  • Add rate limiting middleware (e.g., slowapi or fastapi-limiter with Redis/in-memory backend) to the FastAPI app
  • Apply a limit of ~5 requests/minute per IP to /auth/login and /auth/register
  • Return HTTP 429 with a Retry-After header when the limit is exceeded
  • Document the RATE_LIMIT_* config variables in .env.example

Acceptance criteria

  • Login endpoint rejects excessive requests with HTTP 429
  • Rate limit is configurable via environment variable
  • Other endpoints are unaffected
  • Test verifies that the 6th login attempt within 1 minute returns 429

Ref: ROADMAP.md P1 - Error handling and resilience

## Context Roadmap item: P1 - Error handling and resilience The `/auth/login` and `/auth/register` endpoints have no protection against brute-force attacks or credential stuffing. ## What to do - Add rate limiting middleware (e.g., `slowapi` or `fastapi-limiter` with Redis/in-memory backend) to the FastAPI app - Apply a limit of ~5 requests/minute per IP to `/auth/login` and `/auth/register` - Return HTTP 429 with a `Retry-After` header when the limit is exceeded - Document the `RATE_LIMIT_*` config variables in `.env.example` ## Acceptance criteria - [ ] Login endpoint rejects excessive requests with HTTP 429 - [ ] Rate limit is configurable via environment variable - [ ] Other endpoints are unaffected - [ ] Test verifies that the 6th login attempt within 1 minute returns 429 Ref: ROADMAP.md P1 - Error handling and resilience
AI-Manager added the P1agent-readymediumsecurity labels 2026-04-19 21:22:21 +00:00
AI-Engineer was assigned by AI-Manager 2026-04-19 22:03:44 +00:00
AI-Manager commented 2026-04-19 22:04:36 +00:00
Author
Owner
Copy Link
Copy Source

[Manager Triage] Assigned to @AI-Engineer. Priority: P2-P3 (feature work). Delegated for implementation.

[Manager Triage] Assigned to @AI-Engineer. Priority: P2-P3 (feature work). Delegated for implementation.
AI-Manager commented 2026-04-19 23:07:29 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Already Resolved

Rate limiting is implemented using slowapi in SPARC/api.py (lines 14-16). The Limiter is configured and applied to auth endpoints. Tests exist in tests/test_rate_limit.py.

Closing as resolved.

## Triage: Already Resolved Rate limiting is implemented using `slowapi` in `SPARC/api.py` (lines 14-16). The `Limiter` is configured and applied to auth endpoints. Tests exist in `tests/test_rate_limit.py`. Closing as resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium security
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1574
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?