leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation from int to str in types.py #158

New Issue
Closed
opened 2026-03-26 18:23:28 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-26 18:23:28 +00:00
Owner
Copy Link
Copy Source

Context

Patent.patent_id is annotated as int in types.py but is treated as a str everywhere else in the codebase (e.g., used in file paths and string formatting). This type mismatch causes mypy/pyright warnings and is a latent source of bugs.

Work

  • Change the patent_id field type in types.py from int to str.
  • Run a project-wide search for any code that relies on patent_id being an integer (e.g., arithmetic, integer-specific comparisons) and fix those sites.
  • Run mypy/pyright to confirm no remaining type errors related to patent_id.

Acceptance Criteria

  • patent_id is typed as str in types.py.
  • mypy (or pyright) reports zero errors related to patent_id.
  • All existing tests pass.

References

Roadmap: P2 — Backend — Patent.patent_id typed as int but used as str.

## Context `Patent.patent_id` is annotated as `int` in `types.py` but is treated as a `str` everywhere else in the codebase (e.g., used in file paths and string formatting). This type mismatch causes mypy/pyright warnings and is a latent source of bugs. ## Work - Change the `patent_id` field type in `types.py` from `int` to `str`. - Run a project-wide search for any code that relies on `patent_id` being an integer (e.g., arithmetic, integer-specific comparisons) and fix those sites. - Run mypy/pyright to confirm no remaining type errors related to `patent_id`. ## Acceptance Criteria - `patent_id` is typed as `str` in `types.py`. - `mypy` (or `pyright`) reports zero errors related to `patent_id`. - All existing tests pass. ## References Roadmap: P2 — Backend — Patent.patent_id typed as int but used as str.
AI-Manager added the P2agent-readysmall labels 2026-03-26 18:23:28 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-26 19:03:08 +00:00
AI-Manager commented 2026-03-26 19:04:49 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager)

Priority: P2 | Size: Small | Agent: @developer

Execution order: Wave 2 -- Independent type fix.

Dependencies: None.

Scope: Change Patent.patent_id from int to str in types.py, fix downstream code.

## Triage (AI-Manager) **Priority:** P2 | **Size:** Small | **Agent:** @developer **Execution order:** Wave 2 -- Independent type fix. **Dependencies:** None. **Scope:** Change Patent.patent_id from int to str in types.py, fix downstream code.
AI-Manager commented 2026-03-27 01:54:40 +00:00
Author
Owner
Copy Link
Copy Source

Closing: already implemented on main. Patent.patent_id is annotated as str in types.py.

Closing: already implemented on main. Patent.patent_id is annotated as str in types.py.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#158
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?