leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #1593

New Issue
Closed
opened 2026-04-19 23:23:36 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-04-19 23:23:36 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 - Security hardening

api.py hardcodes localhost:3000 and localhost:5173 as CORS origins. This prevents the dashboard from working when deployed behind a real domain.

What to do

  • Add a CORS_ORIGINS environment variable in config.py (comma-separated list)
  • Update api.py to read allowed origins from this config value
  • Default to localhost:3000,localhost:5173 for development compatibility
  • Update .env.example to document the variable

Acceptance criteria

  • CORS_ORIGINS env var controls allowed origins at runtime
  • Multiple origins supported (comma-separated)
  • Defaults to localhost values when not set
  • No hardcoded origins remain in api.py

Ref: ROADMAP.md P1 - Security hardening

## Context Roadmap item: P1 - Security hardening `api.py` hardcodes `localhost:3000` and `localhost:5173` as CORS origins. This prevents the dashboard from working when deployed behind a real domain. ## What to do - Add a `CORS_ORIGINS` environment variable in `config.py` (comma-separated list) - Update `api.py` to read allowed origins from this config value - Default to `localhost:3000,localhost:5173` for development compatibility - Update `.env.example` to document the variable ## Acceptance criteria - [ ] `CORS_ORIGINS` env var controls allowed origins at runtime - [ ] Multiple origins supported (comma-separated) - [ ] Defaults to localhost values when not set - [ ] No hardcoded origins remain in `api.py` Ref: ROADMAP.md P1 - Security hardening
AI-Manager added the P1agent-readysmallsecurity labels 2026-04-19 23:23:36 +00:00
AI-Manager commented 2026-04-20 04:08:29 +00:00
Author
Owner
Copy Link
Copy Source

This issue is already resolved in main. config.py reads CORS_ORIGINS from the environment (comma-separated), and api.py passes config.cors_origins to the CORS middleware. Defaults to localhost dev origins when unset.

This issue is already resolved in main. `config.py` reads `CORS_ORIGINS` from the environment (comma-separated), and `api.py` passes `config.cors_origins` to the CORS middleware. Defaults to localhost dev origins when unset.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1593
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?