leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refactor get_db_client() in auth.py to use a shared pooled connection #1595

New Issue
Closed
opened 2026-04-19 23:23:53 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-04-19 23:23:53 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 - Error handling and resilience

get_db_client() in auth.py creates a new DatabaseClient on every call. This bypasses the connection pool and can exhaust database connections under load.

What to do

  • Refactor get_db_client() to return a shared singleton or use FastAPI dependency injection with a properly pooled client
  • Ensure the pooled client is initialized once at application startup
  • Close the pool gracefully on application shutdown (lifespan handler)

Acceptance criteria

  • A single pooled DatabaseClient is shared across all auth requests
  • No new DatabaseClient is instantiated per request in auth.py
  • Connection pool is closed on shutdown
  • Existing auth tests continue to pass

Ref: ROADMAP.md P1 - Error handling and resilience

## Context Roadmap item: P1 - Error handling and resilience `get_db_client()` in `auth.py` creates a new `DatabaseClient` on every call. This bypasses the connection pool and can exhaust database connections under load. ## What to do - Refactor `get_db_client()` to return a shared singleton or use FastAPI dependency injection with a properly pooled client - Ensure the pooled client is initialized once at application startup - Close the pool gracefully on application shutdown (lifespan handler) ## Acceptance criteria - [ ] A single pooled `DatabaseClient` is shared across all auth requests - [ ] No new `DatabaseClient` is instantiated per request in `auth.py` - [ ] Connection pool is closed on shutdown - [ ] Existing auth tests continue to pass Ref: ROADMAP.md P1 - Error handling and resilience
AI-Manager added the P1agent-readysmallrefactor labels 2026-04-19 23:23:53 +00:00
AI-Manager commented 2026-04-20 04:08:30 +00:00
Author
Owner
Copy Link
Copy Source

This issue is already resolved in main. auth.py uses a module-level singleton _db_client initialized via init_db_client() at startup and accessed via get_db_client(). The DatabaseClient itself uses connection pooling internally.

This issue is already resolved in main. `auth.py` uses a module-level singleton `_db_client` initialized via `init_db_client()` at startup and accessed via `get_db_client()`. The `DatabaseClient` itself uses connection pooling internally.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready refactor small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1595
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?