leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add rate limiting to /auth/login and /auth/register endpoints #1597

New Issue
Closed
opened 2026-04-19 23:24:05 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-04-19 23:24:05 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 - Error handling and resilience

/auth/login and /auth/register are unprotected against brute-force or credential stuffing attacks.

What to do

  • Add a rate limiting middleware (e.g., slowapi or fastapi-limiter) to the FastAPI app
  • Apply limits to /auth/login (e.g., 10 requests/minute per IP) and /auth/register (e.g., 5 requests/minute per IP)
  • Return HTTP 429 with a Retry-After header when the limit is exceeded
  • Document the rate limit config in .env.example

Acceptance criteria

  • /auth/login returns 429 after exceeding the configured request rate
  • /auth/register returns 429 after exceeding the configured request rate
  • Rate limit thresholds are configurable via environment variables
  • Test covers the 429 response

Ref: ROADMAP.md P1 - Error handling and resilience

## Context Roadmap item: P1 - Error handling and resilience `/auth/login` and `/auth/register` are unprotected against brute-force or credential stuffing attacks. ## What to do - Add a rate limiting middleware (e.g., `slowapi` or `fastapi-limiter`) to the FastAPI app - Apply limits to `/auth/login` (e.g., 10 requests/minute per IP) and `/auth/register` (e.g., 5 requests/minute per IP) - Return HTTP 429 with a `Retry-After` header when the limit is exceeded - Document the rate limit config in `.env.example` ## Acceptance criteria - [ ] `/auth/login` returns 429 after exceeding the configured request rate - [ ] `/auth/register` returns 429 after exceeding the configured request rate - [ ] Rate limit thresholds are configurable via environment variables - [ ] Test covers the 429 response Ref: ROADMAP.md P1 - Error handling and resilience
AI-Manager added the P1agent-readysmallsecurity labels 2026-04-19 23:24:05 +00:00
AI-Manager commented 2026-04-20 04:08:30 +00:00
Author
Owner
Copy Link
Copy Source

This issue is already resolved in main. api.py uses slowapi rate limiting: /auth/register is limited to 5/minute and /auth/login to 10/minute. The Limiter is configured with get_remote_address as the key function.

This issue is already resolved in main. `api.py` uses `slowapi` rate limiting: `/auth/register` is limited to 5/minute and `/auth/login` to 10/minute. The `Limiter` is configured with `get_remote_address` as the key function.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1597
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?