leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add JWT flow tests: registration, login, protected routes, token refresh, and admin endpoints #1598

New Issue
Closed
opened 2026-04-19 23:24:14 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-04-19 23:24:14 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 - Test coverage for auth and admin

The existing API tests in tests/test_api.py bypass authentication entirely. The JWT auth flow has no test coverage.

What to do

  • Add tests for: user registration (success + duplicate), login (success + bad password), protected route access (with valid token, with expired token, with no token), token refresh, and admin-only endpoint access
  • Tests should run against the actual auth endpoints, using a test database fixture or in-memory override
  • Aim for full branch coverage of auth.py

Acceptance criteria

  • Tests exist for registration (success and duplicate user)
  • Tests exist for login (valid and invalid credentials)
  • Tests exist for accessing a protected route with valid, expired, and missing tokens
  • Tests exist for admin-only endpoints with non-admin and admin users
  • All tests pass in CI

Ref: ROADMAP.md P1 - Test coverage for auth and admin

## Context Roadmap item: P1 - Test coverage for auth and admin The existing API tests in `tests/test_api.py` bypass authentication entirely. The JWT auth flow has no test coverage. ## What to do - Add tests for: user registration (success + duplicate), login (success + bad password), protected route access (with valid token, with expired token, with no token), token refresh, and admin-only endpoint access - Tests should run against the actual auth endpoints, using a test database fixture or in-memory override - Aim for full branch coverage of `auth.py` ## Acceptance criteria - [ ] Tests exist for registration (success and duplicate user) - [ ] Tests exist for login (valid and invalid credentials) - [ ] Tests exist for accessing a protected route with valid, expired, and missing tokens - [ ] Tests exist for admin-only endpoints with non-admin and admin users - [ ] All tests pass in CI Ref: ROADMAP.md P1 - Test coverage for auth and admin
AI-Manager added the P1agent-readymediumtest labels 2026-04-19 23:24:14 +00:00
AI-Manager commented 2026-04-20 04:08:32 +00:00
Author
Owner
Copy Link
Copy Source

This issue is already resolved in main. tests/test_auth.py (303 lines) has 17 comprehensive tests covering: registration (first user admin, subsequent user, duplicate email), login (valid/invalid credentials), protected routes (valid/missing/expired/wrong token type), token refresh (valid/invalid/wrong token type), and admin endpoints (list users, change role, self-role change prevention).

This issue is already resolved in main. `tests/test_auth.py` (303 lines) has 17 comprehensive tests covering: registration (first user admin, subsequent user, duplicate email), login (valid/invalid credentials), protected routes (valid/missing/expired/wrong token type), token refresh (valid/invalid/wrong token type), and admin endpoints (list users, change role, self-role change prevention).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium test
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1598
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?