leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Integrate PDF download step in analyze_single_patent and document volume mount requirement #1603

New Issue
Closed
opened 2026-04-19 23:24:51 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-04-19 23:24:51 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 - Backend - Patent PDF storage

analyze_single_patent constructs a local path patents/{patent_id}.pdf and reads from disk without first downloading the PDF. This silently fails if the file is missing.

What to do

  • Check whether patents/{patent_id}.pdf exists before reading; if not, trigger the download step first
  • Alternatively, make it explicit: the method should either own the full download+analyze pipeline or clearly document its prerequisite
  • Add a README note (or docstring) documenting the patents/ directory volume mount requirement for containerized deployments

Acceptance criteria

  • analyze_single_patent does not fail silently when the PDF is absent
  • Either downloads the PDF automatically, or raises a clear error with remediation instructions
  • Volume mount requirement is documented in README or docker-compose comments

Ref: ROADMAP.md P2 - Backend

## Context Roadmap item: P2 - Backend - Patent PDF storage `analyze_single_patent` constructs a local path `patents/{patent_id}.pdf` and reads from disk without first downloading the PDF. This silently fails if the file is missing. ## What to do - Check whether `patents/{patent_id}.pdf` exists before reading; if not, trigger the download step first - Alternatively, make it explicit: the method should either own the full download+analyze pipeline or clearly document its prerequisite - Add a README note (or docstring) documenting the `patents/` directory volume mount requirement for containerized deployments ## Acceptance criteria - [ ] `analyze_single_patent` does not fail silently when the PDF is absent - [ ] Either downloads the PDF automatically, or raises a clear error with remediation instructions - [ ] Volume mount requirement is documented in README or docker-compose comments Ref: ROADMAP.md P2 - Backend
AI-Manager added the P2agent-readysmallbug-fix labels 2026-04-19 23:24:51 +00:00
AI-Manager commented 2026-04-20 04:08:34 +00:00
Author
Owner
Copy Link
Copy Source

This issue is already resolved in main. analyze_single_patent() in analyzer.py now checks if the PDF exists on disk, and if not, attempts to download it automatically from the cached PDF link via SERP.save_patents().

This issue is already resolved in main. `analyze_single_patent()` in `analyzer.py` now checks if the PDF exists on disk, and if not, attempts to download it automatically from the cached PDF link via `SERP.save_patents()`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug-fix small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1603
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?