leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #1608

New Issue
Closed
opened 2026-04-19 23:25:16 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-04-19 23:25:16 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 - CI/CD

There is no linting or type checking in the CI pipeline. Style regressions and type errors can accumulate undetected.

What to do

  • Add a lint job to build.yaml (or extend the test job) that runs:
    • ruff check . for Python linting
    • tsc --noEmit for TypeScript type checking in the frontend directory
  • Fix any existing lint or type errors so CI passes on the current codebase
  • Optionally add ruff format --check for formatting enforcement

Acceptance criteria

  • CI runs ruff check on the Python backend
  • CI runs tsc --noEmit on the TypeScript frontend
  • All current lint/type errors are resolved
  • New PRs cannot merge if lint or type checks fail

Ref: ROADMAP.md P2 - CI/CD

## Context Roadmap item: P2 - CI/CD There is no linting or type checking in the CI pipeline. Style regressions and type errors can accumulate undetected. ## What to do - Add a `lint` job to `build.yaml` (or extend the test job) that runs: - `ruff check .` for Python linting - `tsc --noEmit` for TypeScript type checking in the frontend directory - Fix any existing lint or type errors so CI passes on the current codebase - Optionally add `ruff format --check` for formatting enforcement ## Acceptance criteria - [ ] CI runs `ruff check` on the Python backend - [ ] CI runs `tsc --noEmit` on the TypeScript frontend - [ ] All current lint/type errors are resolved - [ ] New PRs cannot merge if lint or type checks fail Ref: ROADMAP.md P2 - CI/CD
AI-Manager added the P2agent-readysmallci labels 2026-04-19 23:25:16 +00:00
AI-Manager commented 2026-04-20 04:08:36 +00:00
Author
Owner
Copy Link
Copy Source

This issue is already resolved in main. Both CI workflows run ruff check SPARC/ tests/ for Python linting and npx tsc --noEmit for TypeScript type checking.

This issue is already resolved in main. Both CI workflows run `ruff check SPARC/ tests/` for Python linting and `npx tsc --noEmit` for TypeScript type checking.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready ci small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1608
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?