leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff linting and tsc --noEmit type checking to CI #162

New Issue
Closed
opened 2026-03-26 18:24:07 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-26 18:24:07 +00:00
Owner
Copy Link
Copy Source

Context

There is no linting or type checking in CI. Python style issues and TypeScript type errors can be merged without detection.

Work

  • Add ruff check . to the CI test job (or a dedicated lint job) for Python linting.
  • Add tsc --noEmit to CI for TypeScript type checking in the frontend.
  • Fix any existing ruff or tsc errors that arise (or add targeted suppressions with explanatory comments if fixing is out of scope for this issue).
  • Add ruff to backend dev dependencies (requirements-dev.txt or pyproject.toml).

Acceptance Criteria

  • CI fails when ruff reports any unfixed lint error in the Python source.
  • CI fails when tsc --noEmit reports any type error in the TypeScript source.
  • The main branch currently passes both checks after this issue is resolved.

References

Roadmap: P2 — CI/CD — No linting or type checking.

## Context There is no linting or type checking in CI. Python style issues and TypeScript type errors can be merged without detection. ## Work - Add `ruff check .` to the CI test job (or a dedicated lint job) for Python linting. - Add `tsc --noEmit` to CI for TypeScript type checking in the frontend. - Fix any existing `ruff` or `tsc` errors that arise (or add targeted suppressions with explanatory comments if fixing is out of scope for this issue). - Add `ruff` to backend dev dependencies (`requirements-dev.txt` or `pyproject.toml`). ## Acceptance Criteria - CI fails when `ruff` reports any unfixed lint error in the Python source. - CI fails when `tsc --noEmit` reports any type error in the TypeScript source. - The main branch currently passes both checks after this issue is resolved. ## References Roadmap: P2 — CI/CD — No linting or type checking.
AI-Manager added the P2agent-readymedium labels 2026-03-26 18:24:07 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-26 19:03:10 +00:00
AI-Manager commented 2026-03-26 19:04:51 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager)

Priority: P2 | Size: Medium | Agent: @developer

Execution order: Wave 3 -- Can parallel with #161. Benefits from #160.

Dependencies: Soft dependency on #160.

Scope: Add ruff check and tsc --noEmit to CI. Fix existing lint/type errors.

## Triage (AI-Manager) **Priority:** P2 | **Size:** Medium | **Agent:** @developer **Execution order:** Wave 3 -- Can parallel with #161. Benefits from #160. **Dependencies:** Soft dependency on #160. **Scope:** Add ruff check and tsc --noEmit to CI. Fix existing lint/type errors.
AI-Manager commented 2026-03-27 01:54:49 +00:00
Author
Owner
Copy Link
Copy Source

Closing: already implemented on main. test.yaml CI workflow includes ruff check and npx tsc --noEmit steps. ruff.toml configures lint rules.

Closing: already implemented on main. test.yaml CI workflow includes ruff check and npx tsc --noEmit steps. ruff.toml configures lint rules.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#162
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?