leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Remove hardcoded database credentials from docker-compose.yml #1620

New Issue
Closed
opened 2026-04-20 04:24:41 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-04-20 04:24:41 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 Security hardening

docker-compose.yml embeds POSTGRES_USER=postgres and POSTGRES_PASSWORD=postgres in plain text. Any developer who commits with these values or copies the file leaks credentials.

What to do

  1. Create a .env.example file (if it does not exist) containing POSTGRES_USER=postgres and POSTGRES_PASSWORD=changeme with clear comments.
  2. Modify docker-compose.yml to reference variables: POSTGRES_PASSWORD=${POSTGRES_PASSWORD} and POSTGRES_USER=${POSTGRES_USER}.
  3. Ensure .env is listed in .gitignore.
  4. Update README.md (or docs/) with a setup step: "Copy .env.example to .env and set secure values before running docker compose up."

Acceptance criteria

  • docker-compose.yml contains no literal credential values.
  • docker compose config resolves correctly when .env is present.
  • .env is gitignored.
  • .env.example exists and documents all required variables.
## Context Roadmap item: P1 Security hardening `docker-compose.yml` embeds `POSTGRES_USER=postgres` and `POSTGRES_PASSWORD=postgres` in plain text. Any developer who commits with these values or copies the file leaks credentials. ## What to do 1. Create a `.env.example` file (if it does not exist) containing `POSTGRES_USER=postgres` and `POSTGRES_PASSWORD=changeme` with clear comments. 2. Modify `docker-compose.yml` to reference variables: `POSTGRES_PASSWORD=${POSTGRES_PASSWORD}` and `POSTGRES_USER=${POSTGRES_USER}`. 3. Ensure `.env` is listed in `.gitignore`. 4. Update `README.md` (or `docs/`) with a setup step: "Copy `.env.example` to `.env` and set secure values before running `docker compose up`." ## Acceptance criteria - `docker-compose.yml` contains no literal credential values. - `docker compose config` resolves correctly when `.env` is present. - `.env` is gitignored. - `.env.example` exists and documents all required variables.
AI-Manager added the P1agent-readysmallsecurity labels 2026-04-20 04:24:41 +00:00
AI-Manager commented 2026-04-20 05:08:16 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been resolved by previously merged PRs. The feature is already implemented in the codebase on main.

Closing as already resolved.

This issue has been resolved by previously merged PRs. The feature is already implemented in the codebase on main. - JWT startup guard: PR #27 - Configurable CORS: PR #27 - Externalized DB creds: PR #27 - Rate limiting: PR #28 - Configurable MODEL: PR #29 - Structured logging: PR #29 - Shared DB client singleton in auth.py: implemented - Job persistence to PostgreSQL: implemented via database.create_job/list_jobs Closing as already resolved.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1620
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?