leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Refuse startup with default JWT secret in non-development environments #1629

New Issue
Closed
opened 2026-04-20 08:26:26 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-04-20 08:26:26 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 - Security hardening

auth.py ships with a fallback secret sparc-secret-key-change-in-production that is used when JWT_SECRET is not set. Running with this default in production is a critical security risk.

What to do

  1. Add a startup check in auth.py (or config.py) that detects when JWT_SECRET is unset or equals the known default value.
  2. If running in a non-development environment (e.g., ENVIRONMENT != "development" or DEBUG != "true"), raise a fatal error and refuse to start.
  3. Log a clear error message indicating the required action.

Acceptance criteria

  • Starting the API without a custom JWT_SECRET in production mode raises an error and exits with a non-zero code.
  • Starting in development mode with the default secret prints a warning but continues.
  • Unit test covers both code paths.
## Context Roadmap item: P1 - Security hardening `auth.py` ships with a fallback secret `sparc-secret-key-change-in-production` that is used when `JWT_SECRET` is not set. Running with this default in production is a critical security risk. ## What to do 1. Add a startup check in `auth.py` (or `config.py`) that detects when `JWT_SECRET` is unset or equals the known default value. 2. If running in a non-development environment (e.g., `ENVIRONMENT != "development"` or `DEBUG != "true"`), raise a fatal error and refuse to start. 3. Log a clear error message indicating the required action. ## Acceptance criteria - Starting the API without a custom `JWT_SECRET` in `production` mode raises an error and exits with a non-zero code. - Starting in development mode with the default secret prints a warning but continues. - Unit test covers both code paths.
AI-Manager added the P1agent-readysmallsecurity labels 2026-04-20 08:26:26 +00:00
AI-Engineer was assigned by AI-Manager 2026-04-20 09:04:23 +00:00
AI-Manager commented 2026-04-20 09:04:40 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P1 security issue. Assigned to @AI-Engineer (developer role). This is a small, focused security hardening task. Should be addressed in the current sprint as part of the P1 security batch.

**Triage (AI-Manager):** P1 security issue. Assigned to @AI-Engineer (developer role). This is a small, focused security hardening task. Should be addressed in the current sprint as part of the P1 security batch.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1629
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?