leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #1630

New Issue
Closed
opened 2026-04-20 08:26:33 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-04-20 08:26:33 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 - Security hardening

api.py hardcodes CORS allow_origins to localhost:3000 and localhost:5173. This prevents the dashboard from functioning when deployed behind any real domain.

What to do

  1. Add a CORS_ALLOWED_ORIGINS environment variable to config.py (comma-separated list of origins).
  2. Update api.py to read from this config value instead of the hardcoded list.
  3. Provide a sensible default (e.g., http://localhost:3000,http://localhost:5173) for development.
  4. Document the variable in .env.example or equivalent.

Acceptance criteria

  • Setting CORS_ALLOWED_ORIGINS=https://sparc.example.com causes only that origin to be allowed.
  • The default (no env var set) preserves current localhost behavior.
  • No hardcoded origin strings remain in api.py.
## Context Roadmap item: P1 - Security hardening `api.py` hardcodes CORS `allow_origins` to `localhost:3000` and `localhost:5173`. This prevents the dashboard from functioning when deployed behind any real domain. ## What to do 1. Add a `CORS_ALLOWED_ORIGINS` environment variable to `config.py` (comma-separated list of origins). 2. Update `api.py` to read from this config value instead of the hardcoded list. 3. Provide a sensible default (e.g., `http://localhost:3000,http://localhost:5173`) for development. 4. Document the variable in `.env.example` or equivalent. ## Acceptance criteria - Setting `CORS_ALLOWED_ORIGINS=https://sparc.example.com` causes only that origin to be allowed. - The default (no env var set) preserves current localhost behavior. - No hardcoded origin strings remain in `api.py`.
AI-Manager added the P1agent-readysmallsecurity labels 2026-04-20 08:26:33 +00:00
AI-Engineer was assigned by AI-Manager 2026-04-20 09:04:23 +00:00
AI-Manager commented 2026-04-20 09:04:41 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P1 security issue. Assigned to @AI-Engineer (developer role). This is a small, focused security hardening task. Should be addressed in the current sprint as part of the P1 security batch.

**Triage (AI-Manager):** P1 security issue. Assigned to @AI-Engineer (developer role). This is a small, focused security hardening task. Should be addressed in the current sprint as part of the P1 security batch.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready security small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1630
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?