leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix analyze_single_patent to download PDF before reading from disk #1640

New Issue
Closed
opened 2026-04-20 08:27:59 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-04-20 08:27:59 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 - Backend: analyze_single_patent assumes local file path

analyze_single_patent constructs patents/{patent_id}.pdf and reads it from disk, but never downloads the file first. Calling this method on a patent not yet cached will silently fail or raise a file-not-found error.

What to do

  1. Before reading patents/{patent_id}.pdf, check if the file exists.
  2. If it does not exist, trigger the download step (integrate with the existing SerpAPI/PDF download flow).
  3. If a download is not possible (e.g., no URL available), raise a clear, descriptive exception.
  4. Add a unit test covering both the cached and uncached code paths.

Acceptance criteria

  • Calling analyze_single_patent for a patent with no cached PDF automatically downloads it.
  • An informative error is raised if the PDF cannot be obtained.
  • The existing behavior for already-cached PDFs is unchanged.
## Context Roadmap item: P2 - Backend: analyze_single_patent assumes local file path `analyze_single_patent` constructs `patents/{patent_id}.pdf` and reads it from disk, but never downloads the file first. Calling this method on a patent not yet cached will silently fail or raise a file-not-found error. ## What to do 1. Before reading `patents/{patent_id}.pdf`, check if the file exists. 2. If it does not exist, trigger the download step (integrate with the existing SerpAPI/PDF download flow). 3. If a download is not possible (e.g., no URL available), raise a clear, descriptive exception. 4. Add a unit test covering both the cached and uncached code paths. ## Acceptance criteria - Calling `analyze_single_patent` for a patent with no cached PDF automatically downloads it. - An informative error is raised if the PDF cannot be obtained. - The existing behavior for already-cached PDFs is unchanged.
AI-Manager added the P2agent-readysmallbug-fix labels 2026-04-20 08:27:59 +00:00
AI-Engineer was assigned by AI-Manager 2026-04-20 09:04:24 +00:00
AI-Manager commented 2026-04-20 09:04:53 +00:00
Author
Owner
Copy Link
Copy Source

Triage (AI-Manager): P2 bug fix. Assigned to @AI-Engineer (developer role). Small, focused fix.

**Triage (AI-Manager):** P2 bug fix. Assigned to @AI-Engineer (developer role). Small, focused fix.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready bug-fix small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1640
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?