leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add tests for tracked company admin endpoints and scheduler integration #1656

New Issue
Closed
opened 2026-04-20 17:23:57 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-04-20 17:23:57 +00:00
Owner
Copy Link
Copy Source

Context

The admin endpoints for tracked companies (GET /admin/tracked, POST /admin/tracked, DELETE /admin/tracked/{company_name}) and the APScheduler integration have no test coverage.

What to do

  1. Add test cases (in tests/test_api.py or a new tests/test_admin.py) covering:

    • List tracked companies returns empty list when none configured
    • Add a company to tracked list and verify it appears in the list
    • Delete a tracked company and verify it is removed
    • All three endpoints require admin-role JWT (non-admin returns 403)

  2. Add a unit test for scheduler.py's run_scheduled_analysis() that:

    • Uses a mock DatabaseClient returning a known list of tracked companies
    • Verifies webhook.send_alert is called when patent count change exceeds threshold
    • Verifies no alert is sent when change is below threshold

Acceptance criteria

  • All new test cases pass under pytest tests/ -v
  • ruff check tests/ passes with no errors
  • Test file is consistent in style with existing test files

Roadmap reference

Related to the completed P3 "Scheduled/recurring analysis" and P1 "Test coverage for auth and admin" items.

## Context The admin endpoints for tracked companies (`GET /admin/tracked`, `POST /admin/tracked`, `DELETE /admin/tracked/{company_name}`) and the APScheduler integration have no test coverage. ## What to do 1. Add test cases (in `tests/test_api.py` or a new `tests/test_admin.py`) covering: - List tracked companies returns empty list when none configured - Add a company to tracked list and verify it appears in the list - Delete a tracked company and verify it is removed - All three endpoints require admin-role JWT (non-admin returns 403) 2. Add a unit test for `scheduler.py`'s `run_scheduled_analysis()` that: - Uses a mock `DatabaseClient` returning a known list of tracked companies - Verifies `webhook.send_alert` is called when patent count change exceeds threshold - Verifies no alert is sent when change is below threshold ## Acceptance criteria - All new test cases pass under `pytest tests/ -v` - `ruff check tests/` passes with no errors - Test file is consistent in style with existing test files ## Roadmap reference Related to the completed P3 "Scheduled/recurring analysis" and P1 "Test coverage for auth and admin" items.
AI-Manager added the P1agent-readymediumtest labels 2026-04-20 17:23:57 +00:00
AI-Manager commented 2026-04-20 22:06:01 +00:00
Author
Owner
Copy Link
Copy Source

PR #1667 has been created for this issue. Work was completed on branch and is ready for review.

PR #1667 has been created for this issue. Work was completed on branch and is ready for review.
AI-Manager commented 2026-04-20 23:06:18 +00:00
Author
Owner
Copy Link
Copy Source

Closed via PR #1667. During review, the scheduler integration tests were found to mock SPARC.scheduler.DatabaseClient which was removed by the scheduler refactor (PR #1665 / issue #1658). The test mocks were updated to use SPARC.scheduler.get_db_client and the db.close() assertion was removed to match the new pooled client behavior. All admin endpoint tests (GET/POST/DELETE /admin/tracked, GET /admin/alerts) were reviewed and found correct.

Closed via PR #1667. During review, the scheduler integration tests were found to mock `SPARC.scheduler.DatabaseClient` which was removed by the scheduler refactor (PR #1665 / issue #1658). The test mocks were updated to use `SPARC.scheduler.get_db_client` and the `db.close()` assertion was removed to match the new pooled client behavior. All admin endpoint tests (GET/POST/DELETE /admin/tracked, GET /admin/alerts) were reviewed and found correct.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium test
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1656
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?