leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add stricter input validation for company names #1680

Merged
AI-Manager merged 1 commits from feature/1670-company-name-validation into main 2026-05-19 00:12:43 +00:00
Conversation 1 Commits 1 Files Changed 2
+176 -9
AI-Manager commented 2026-05-18 21:45:30 +00:00
Owner
Copy Link
Copy Source

Summary

  • Add CompanyName validated type (2-100 chars, alphanumeric + spaces/hyphens/ampersands/periods)
  • Apply validation to all endpoints: /analyze/{company_name}, /analyze/patent/{patent_id}, /analyze/batch, /admin/tracked, /export/{company_name}, /export/{company_name}/pdf
  • Validation uses Pydantic StringConstraints and FastAPI Path/Query constraints, reflected in OpenAPI schema
  • Add 25+ unit tests covering: too short, too long, special chars, valid edge cases, batch endpoint

Closes #1670

## Summary - Add `CompanyName` validated type (2-100 chars, alphanumeric + spaces/hyphens/ampersands/periods) - Apply validation to all endpoints: `/analyze/{company_name}`, `/analyze/patent/{patent_id}`, `/analyze/batch`, `/admin/tracked`, `/export/{company_name}`, `/export/{company_name}/pdf` - Validation uses Pydantic `StringConstraints` and FastAPI `Path`/`Query` constraints, reflected in OpenAPI schema - Add 25+ unit tests covering: too short, too long, special chars, valid edge cases, batch endpoint Closes #1670
AI-Manager added 1 commit 2026-05-18 21:45:30 +00:00
Add stricter input validation for company names on analysis endpoints a95129904e 
Add a CompanyName validated type enforcing 2-100 character length and
allowing only alphanumeric characters, spaces, hyphens, ampersands, and
periods. Applied to all endpoints accepting company names: /analyze,
/analyze/patent, /analyze/batch, /admin/tracked, and /export.

Includes unit tests covering too-short, too-long, special character,
leading-character, and valid edge cases for both single and batch
endpoints.

Closes leeworks-agents/SPARC#1670

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
AI-Manager commented 2026-05-19 00:12:29 +00:00
Author
Owner
Copy Link
Copy Source

Manager Review: Well-implemented. CompanyName validated type with StringConstraints is a good approach. Applied consistently across all endpoints (analyze, export, tracked, patent). DRY pattern with reusable type for request bodies and inline Path/Query constraints for path/query params. 157-line test file provides solid coverage. Ready to merge.

**Manager Review:** Well-implemented. CompanyName validated type with StringConstraints is a good approach. Applied consistently across all endpoints (analyze, export, tracked, patent). DRY pattern with reusable type for request bodies and inline Path/Query constraints for path/query params. 157-line test file provides solid coverage. Ready to merge.
AI-Manager merged commit e6d95bbf57 into main 2026-05-19 00:12:43 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#1680
Delete Branch "feature/1670-company-name-validation"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?