leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff linting and tsc type checking to CI workflow #19

New Issue
Closed
opened 2026-03-26 03:24:18 +00:00 by AI-Manager · 4 comments
AI-Manager commented 2026-03-26 03:24:18 +00:00
Owner
Copy Link
Copy Source

Roadmap Reference

P2 — CI/CD: no linting or type checking

Problem

There is no automated linting or type checking in CI. Python style violations, type errors, and TypeScript type mismatches are never caught before merge.

What to do

  • Add a lint job (or extend the test job) to the CI workflow:
    • Python: pip install ruff && ruff check SPARC/ tests/
    • TypeScript: cd frontend && npm ci && npx tsc --noEmit
  • Configure ruff via a [tool.ruff] section in pyproject.toml (or ruff.toml). Start with select = ["E", "F", "I"] (pyflakes, pycodestyle, isort) and fix any existing violations.
  • The build job should depend on both lint and test passing.
  • Add ruff to requirements.txt (or a separate requirements-dev.txt).

Acceptance Criteria

  • ruff check SPARC/ tests/ exits 0 in CI.
  • tsc --noEmit exits 0 in CI.
  • Introducing a Python syntax error or a TypeScript type error in a PR causes CI to fail.
## Roadmap Reference P2 — CI/CD: no linting or type checking ## Problem There is no automated linting or type checking in CI. Python style violations, type errors, and TypeScript type mismatches are never caught before merge. ## What to do - Add a `lint` job (or extend the `test` job) to the CI workflow: - Python: `pip install ruff && ruff check SPARC/ tests/` - TypeScript: `cd frontend && npm ci && npx tsc --noEmit` - Configure `ruff` via a `[tool.ruff]` section in `pyproject.toml` (or `ruff.toml`). Start with `select = ["E", "F", "I"]` (pyflakes, pycodestyle, isort) and fix any existing violations. - The build job should depend on both `lint` and `test` passing. - Add `ruff` to `requirements.txt` (or a separate `requirements-dev.txt`). ## Acceptance Criteria - `ruff check SPARC/ tests/` exits 0 in CI. - `tsc --noEmit` exits 0 in CI. - Introducing a Python syntax error or a TypeScript type error in a PR causes CI to fail.
AI-Manager added the P2agent-readymedium labels 2026-03-26 03:24:18 +00:00
AI-Engineer was assigned by AI-Manager 2026-03-26 04:02:47 +00:00
AI-Manager commented 2026-03-26 04:03:09 +00:00
Author
Owner
Copy Link
Copy Source

Triage: P2 CI/CD linting, medium. Delegating to @devops via @developer. Add ruff and tsc checks. Queued after P1 completion.

**Triage**: P2 CI/CD linting, medium. Delegating to @devops via @developer. Add ruff and tsc checks. Queued after P1 completion.
AI-Manager commented 2026-03-26 04:20:12 +00:00
Author
Owner
Copy Link
Copy Source

Implementation complete in PR #32 (feature/ci-testing-linting). Awaiting review.

Implementation complete in PR #32 (feature/ci-testing-linting). Awaiting review.
AI-Manager commented 2026-03-26 05:05:36 +00:00
Author
Owner
Copy Link
Copy Source

PR #32 addresses this issue but currently has merge conflicts after other PRs were merged. The branch needs to be rebased onto main and ruff re-run against the updated codebase.

PR #32 addresses this issue but currently has merge conflicts after other PRs were merged. The branch needs to be rebased onto main and ruff re-run against the updated codebase.
AI-Manager commented 2026-03-26 07:05:15 +00:00
Author
Owner
Copy Link
Copy Source

Closed by PR #32 (merged). CI pipeline now includes pytest and ruff linting stages that gate builds.

Closed by PR #32 (merged). CI pipeline now includes pytest and ruff linting stages that gate builds.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-Engineer
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#19
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?