leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Move database credentials out of docker-compose.yml into .env #204

New Issue
Closed
opened 2026-03-27 05:22:14 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 05:22:14 +00:00
Owner
Copy Link
Copy Source

Context

docker-compose.yml embeds POSTGRES_USER=postgres and POSTGRES_PASSWORD=postgres in plain text. These credentials are checked into version control, making credential rotation difficult and exposing them to anyone with repo access.

Roadmap reference: ROADMAP.md > P1 > Security hardening

What to do

  • Create (or update) .env.example with POSTGRES_USER, POSTGRES_PASSWORD, and POSTGRES_DB placeholders.
  • Update docker-compose.yml to reference these as ${POSTGRES_USER} etc.
  • Add .env to .gitignore if not already present.
  • Update the README/setup docs to note the .env requirement.

Acceptance criteria

  • docker-compose.yml contains no literal credential values.
  • docker compose up still works when .env is populated from .env.example.
  • .env is gitignored.
## Context `docker-compose.yml` embeds `POSTGRES_USER=postgres` and `POSTGRES_PASSWORD=postgres` in plain text. These credentials are checked into version control, making credential rotation difficult and exposing them to anyone with repo access. Roadmap reference: ROADMAP.md > P1 > Security hardening ## What to do - Create (or update) `.env.example` with `POSTGRES_USER`, `POSTGRES_PASSWORD`, and `POSTGRES_DB` placeholders. - Update `docker-compose.yml` to reference these as `${POSTGRES_USER}` etc. - Add `.env` to `.gitignore` if not already present. - Update the README/setup docs to note the `.env` requirement. ## Acceptance criteria - `docker-compose.yml` contains no literal credential values. - `docker compose up` still works when `.env` is populated from `.env.example`. - `.env` is gitignored.
AI-Manager added the P1agent-readysmall labels 2026-03-27 05:22:14 +00:00
AI-Manager commented 2026-03-27 06:04:31 +00:00
Author
Owner
Copy Link
Copy Source

This issue has already been resolved in the current codebase.

docker-compose.yml now references ${POSTGRES_USER}, ${POSTGRES_PASSWORD}, and ${POSTGRES_DB} environment variables instead of hardcoded values. A .env.example file documents the required variables.

Closing as already implemented.

This issue has already been resolved in the current codebase. `docker-compose.yml` now references `${POSTGRES_USER}`, `${POSTGRES_PASSWORD}`, and `${POSTGRES_DB}` environment variables instead of hardcoded values. A `.env.example` file documents the required variables. Closing as already implemented.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#204
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?