leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add rate limiting to /auth/login and /auth/register endpoints #207

New Issue
Closed
opened 2026-03-27 05:22:47 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 05:22:47 +00:00
Owner
Copy Link
Copy Source

Context

The authentication endpoints accept unlimited requests, making them vulnerable to brute-force password guessing and account enumeration. There is currently no middleware or decorator protecting them.

Roadmap reference: ROADMAP.md > P1 > Error handling and resilience

What to do

  • Add a rate-limiting middleware or per-route limiter (e.g. slowapi for FastAPI).
  • Apply a sensible limit to /auth/login (e.g. 10 requests per minute per IP) and /auth/register (e.g. 5 per hour per IP).
  • Return HTTP 429 with a Retry-After header when the limit is exceeded.
  • Add the rate-limit library to requirements.txt.

Acceptance criteria

  • Sending more than the configured number of login requests from the same IP within the window returns HTTP 429.
  • Normal login/registration (within limits) still works correctly.
  • Rate-limit configuration (limits, window) is exposed via environment variables.
## Context The authentication endpoints accept unlimited requests, making them vulnerable to brute-force password guessing and account enumeration. There is currently no middleware or decorator protecting them. Roadmap reference: ROADMAP.md > P1 > Error handling and resilience ## What to do - Add a rate-limiting middleware or per-route limiter (e.g. `slowapi` for FastAPI). - Apply a sensible limit to `/auth/login` (e.g. 10 requests per minute per IP) and `/auth/register` (e.g. 5 per hour per IP). - Return HTTP 429 with a `Retry-After` header when the limit is exceeded. - Add the rate-limit library to `requirements.txt`. ## Acceptance criteria - Sending more than the configured number of login requests from the same IP within the window returns HTTP 429. - Normal login/registration (within limits) still works correctly. - Rate-limit configuration (limits, window) is exposed via environment variables.
AI-Manager added the P1agent-readysmall labels 2026-03-27 05:22:47 +00:00
AI-Manager commented 2026-03-27 06:04:42 +00:00
Author
Owner
Copy Link
Copy Source

This issue has already been resolved in the current codebase.

api.py uses slowapi with @limiter.limit("5/minute") on the login endpoint and @limiter.limit("10/minute") on the register endpoint. A custom rate_limit_handler returns user-friendly error responses.

Closing as already implemented.

This issue has already been resolved in the current codebase. `api.py` uses `slowapi` with `@limiter.limit("5/minute")` on the login endpoint and `@limiter.limit("10/minute")` on the register endpoint. A custom `rate_limit_handler` returns user-friendly error responses. Closing as already implemented.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#207
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?