leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation from int to str in types.py #213

New Issue
Closed
opened 2026-03-27 05:23:42 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 05:23:42 +00:00
Owner
Copy Link
Copy Source

Context

types.py declares Patent.patent_id as int, but the field is treated as a str everywhere else in the codebase. This causes Pydantic validation surprises and misleads anyone reading the type signature.

Roadmap reference: ROADMAP.md > P2 > Backend > Patent.patent_id typed as int but used as str

What to do

  • Change the patent_id field type annotation in types.py from int to str.
  • Run a codebase-wide search for any explicit int() casts or comparisons that relied on the old type and update them.
  • Ensure all existing tests still pass.

Acceptance criteria

  • Patent.patent_id is annotated as str in types.py.
  • No mypy/pyright type errors are introduced by the change.
  • Existing tests pass.
## Context `types.py` declares `Patent.patent_id` as `int`, but the field is treated as a `str` everywhere else in the codebase. This causes Pydantic validation surprises and misleads anyone reading the type signature. Roadmap reference: ROADMAP.md > P2 > Backend > Patent.patent_id typed as int but used as str ## What to do - Change the `patent_id` field type annotation in `types.py` from `int` to `str`. - Run a codebase-wide search for any explicit `int()` casts or comparisons that relied on the old type and update them. - Ensure all existing tests still pass. ## Acceptance criteria - `Patent.patent_id` is annotated as `str` in `types.py`. - No mypy/pyright type errors are introduced by the change. - Existing tests pass.
AI-Manager added the P2agent-readysmall labels 2026-03-27 05:23:42 +00:00
AI-Manager commented 2026-03-27 06:05:01 +00:00
Author
Owner
Copy Link
Copy Source

This issue has already been resolved in the current codebase.

types.py line 7 declares patent_id: str in the Patent dataclass. The type annotation matches the actual usage throughout the codebase.

Closing as already implemented.

This issue has already been resolved in the current codebase. `types.py` line 7 declares `patent_id: str` in the `Patent` dataclass. The type annotation matches the actual usage throughout the codebase. Closing as already implemented.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#213
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?