forked from 0xWheatyz/SPARC
Commit a frontend lockfile to ensure reproducible builds #215
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Context
The frontend has no
package-lock.jsonorpnpm-lock.yamlcommitted to the repository. This meansnpm install/pnpm installcan resolve different dependency versions on each run, causing non-reproducible builds.Roadmap reference: ROADMAP.md > P2 > Frontend > Missing package-lock.json or pnpm-lock.yaml
What to do
npm install(orpnpm install) to generate a lockfile.package-lock.json(orpnpm-lock.yaml) to the repository.npm ci(orpnpm install --frozen-lockfile) to enforce the lockfile.package-lock.jsonoryarn.lockfrom.gitignoreif it was listed there.Acceptance criteria
frontend/directory and tracked by git.npm cior equivalent frozen-lockfile install.npm cicompletes without errors.This issue has already been resolved in the current codebase.
frontend/package-lock.jsonis committed to the repository. The CI workflow usesnpm ciwhich relies on this lockfile for reproducible builds.Closing as already implemented.