leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add ruff (Python) and tsc --noEmit (TypeScript) linting to CI #217

New Issue
Closed
opened 2026-03-27 05:24:22 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 05:24:22 +00:00
Owner
Copy Link
Copy Source

Context

The CI pipeline has no linting or type-checking step. Style violations and TypeScript type errors go undetected until a developer runs checks locally (if at all).

Roadmap reference: ROADMAP.md > P2 > CI/CD > No linting or type checking

What to do

  • Add ruff to requirements.txt (or requirements-dev.txt) and configure it in pyproject.toml or ruff.toml.
  • Add a lint job to CI that runs ruff check . on the backend.
  • Add a typecheck job (or step) that runs tsc --noEmit on the frontend.
  • Both checks should block merge on failure.

Acceptance criteria

  • ruff check . runs in CI and a ruff violation causes the pipeline to fail.
  • tsc --noEmit runs in CI and a TypeScript error causes the pipeline to fail.
  • Both checks pass on the current codebase (fix any pre-existing violations as part of this issue).
## Context The CI pipeline has no linting or type-checking step. Style violations and TypeScript type errors go undetected until a developer runs checks locally (if at all). Roadmap reference: ROADMAP.md > P2 > CI/CD > No linting or type checking ## What to do - Add `ruff` to `requirements.txt` (or `requirements-dev.txt`) and configure it in `pyproject.toml` or `ruff.toml`. - Add a `lint` job to CI that runs `ruff check .` on the backend. - Add a `typecheck` job (or step) that runs `tsc --noEmit` on the frontend. - Both checks should block merge on failure. ## Acceptance criteria - `ruff check .` runs in CI and a ruff violation causes the pipeline to fail. - `tsc --noEmit` runs in CI and a TypeScript error causes the pipeline to fail. - Both checks pass on the current codebase (fix any pre-existing violations as part of this issue).
AI-Manager added the P2agent-readymedium labels 2026-03-27 05:24:22 +00:00
AI-Manager commented 2026-03-27 06:05:14 +00:00
Author
Owner
Copy Link
Copy Source

This issue has already been resolved in the current codebase.

.gitea/workflows/test.yaml includes both a ruff check SPARC/ tests/ step and a npx tsc --noEmit step for TypeScript type checking. A ruff.toml configuration file exists in the repo root.

Closing as already implemented.

This issue has already been resolved in the current codebase. `.gitea/workflows/test.yaml` includes both a `ruff check SPARC/ tests/` step and a `npx tsc --noEmit` step for TypeScript type checking. A `ruff.toml` configuration file exists in the repo root. Closing as already implemented.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#217
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?