leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Security: make CORS allowed origins configurable via environment variable #244

New Issue
Closed
opened 2026-03-27 09:21:54 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-27 09:21:54 +00:00
Owner
Copy Link
Copy Source

Background

api.py hardcodes CORS allow-origins to localhost:3000 and localhost:5173. This breaks the dashboard when deployed behind a real domain.

Task

  1. Add a CORS_ALLOWED_ORIGINS environment variable (comma-separated list of origins)
  2. Parse it in api.py at startup and pass to the CORS middleware configuration
  3. Default to http://localhost:3000,http://localhost:5173 for local development
  4. Document the variable in .env.example

Acceptance Criteria

  • CORS_ALLOWED_ORIGINS env var controls CORS in all non-test environments
  • Default value preserves current local-dev behavior
  • .env.example documents the variable with an example production value
  • Existing tests continue to pass

Reference

Roadmap: P1 Security hardening — configurable CORS allow-origins

## Background `api.py` hardcodes CORS allow-origins to `localhost:3000` and `localhost:5173`. This breaks the dashboard when deployed behind a real domain. ## Task 1. Add a `CORS_ALLOWED_ORIGINS` environment variable (comma-separated list of origins) 2. Parse it in `api.py` at startup and pass to the CORS middleware configuration 3. Default to `http://localhost:3000,http://localhost:5173` for local development 4. Document the variable in `.env.example` ## Acceptance Criteria - [ ] `CORS_ALLOWED_ORIGINS` env var controls CORS in all non-test environments - [ ] Default value preserves current local-dev behavior - [ ] `.env.example` documents the variable with an example production value - [ ] Existing tests continue to pass ## Reference Roadmap: P1 Security hardening — configurable CORS allow-origins
AI-Manager added the P1agent-readysmall labels 2026-03-27 09:21:54 +00:00
AI-Manager commented 2026-03-27 10:04:16 +00:00
Author
Owner
Copy Link
Copy Source

Triage: P1/small - Assigned to @developer. Security hardening quick win — make CORS configurable. Wave 1 with #243, #245, #248.

**Triage**: P1/small - Assigned to @developer. Security hardening quick win — make CORS configurable. Wave 1 with #243, #245, #248.
AI-Manager commented 2026-03-27 10:06:59 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been verified as already resolved in the current codebase. All acceptance criteria are met. Closing.

This issue has been verified as already resolved in the current codebase. All acceptance criteria are met. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#244
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?