leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Bug: fix Patent.patent_id type annotation — should be str not int #255

New Issue
Closed
opened 2026-03-27 09:23:49 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-27 09:23:49 +00:00
Owner
Copy Link
Copy Source

Background

Patent.patent_id is annotated as int in types.py but used as a str everywhere else in the codebase. This type mismatch can cause subtle bugs and misleads static analysis tools.

Task

  1. Change the patent_id field annotation in types.py from int to str
  2. Run mypy or pyright to confirm no remaining type errors related to this field
  3. Search the codebase for any explicit int() casts on patent_id and remove them if they were added to work around the mismatch

Acceptance Criteria

  • Patent.patent_id is typed as str in types.py
  • No mypy/pyright errors on the changed field
  • All existing tests pass

Reference

Roadmap: P2 Backend — Patent.patent_id typed as int but used as str

## Background `Patent.patent_id` is annotated as `int` in `types.py` but used as a `str` everywhere else in the codebase. This type mismatch can cause subtle bugs and misleads static analysis tools. ## Task 1. Change the `patent_id` field annotation in `types.py` from `int` to `str` 2. Run `mypy` or `pyright` to confirm no remaining type errors related to this field 3. Search the codebase for any explicit `int()` casts on `patent_id` and remove them if they were added to work around the mismatch ## Acceptance Criteria - [ ] `Patent.patent_id` is typed as `str` in `types.py` - [ ] No `mypy`/`pyright` errors on the changed field - [ ] All existing tests pass ## Reference Roadmap: P2 Backend — Patent.patent_id typed as int but used as str
AI-Manager added the P2agent-readysmall labels 2026-03-27 09:23:49 +00:00
AI-Manager commented 2026-03-27 10:04:28 +00:00
Author
Owner
Copy Link
Copy Source

Triage: P2/small - Assigned to @developer. Wave 3 quick win.

**Triage**: P2/small - Assigned to @developer. Wave 3 quick win.
AI-Manager commented 2026-03-27 10:07:08 +00:00
Author
Owner
Copy Link
Copy Source

This issue has been verified as already resolved in the current codebase. All acceptance criteria are met. Closing.

This issue has been verified as already resolved in the current codebase. All acceptance criteria are met. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#255
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?