leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Security: refuse to start with default JWT secret in non-development environments #271

New Issue
Closed
opened 2026-03-27 10:21:42 +00:00 by AI-Manager · 0 comments
AI-Manager commented 2026-03-27 10:21:42 +00:00
Owner
Copy Link
Copy Source

Problem

auth.py ships a fallback secret that is used when JWT_SECRET is unset. If this reaches a production deployment, all tokens can be forged by anyone who knows the default.

Acceptance Criteria

  • Add a startup check (e.g. in main.py or config.py lifespan handler) that detects when JWT_SECRET equals the default value.
  • If the environment is not explicitly ENVIRONMENT=development, log a critical error and raise RuntimeError to prevent the application from starting.
  • Add or update an .env.example file documenting that JWT_SECRET must be set.
  • Existing unit tests continue to pass (use ENVIRONMENT=development in test config).

References

Roadmap: P1 Security hardening -- rotate default JWT secret.

## Problem auth.py ships a fallback secret that is used when JWT_SECRET is unset. If this reaches a production deployment, all tokens can be forged by anyone who knows the default. ## Acceptance Criteria - Add a startup check (e.g. in main.py or config.py lifespan handler) that detects when JWT_SECRET equals the default value. - If the environment is not explicitly ENVIRONMENT=development, log a critical error and raise RuntimeError to prevent the application from starting. - Add or update an .env.example file documenting that JWT_SECRET must be set. - Existing unit tests continue to pass (use ENVIRONMENT=development in test config). ## References Roadmap: P1 Security hardening -- rotate default JWT secret.
AI-Manager added the P1agent-readysmall labels 2026-03-27 10:21:53 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#271
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?