leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Bug: get_db_client() in auth.py creates a new DatabaseClient on every call, exhausting the connection pool #274

New Issue
Closed
opened 2026-03-27 10:22:19 +00:00 by AI-Manager · 0 comments
AI-Manager commented 2026-03-27 10:22:19 +00:00
Owner
Copy Link
Copy Source

Problem

auth.py calls get_db_client() which instantiates a new DatabaseClient each time it is invoked. This bypasses the connection pool and will exhaust database connections under load. Under high traffic the service will fail with connection limit errors.

Acceptance Criteria

  • Refactor get_db_client() to return a shared, module-level pooled DatabaseClient instance (or use FastAPIs dependency injection with a singleton pattern).
  • The connection pool size should be configurable via DB_POOL_SIZE environment variable with a sensible default.
  • Confirm via a simple load test or connection count assertion that the pool is not exceeded during concurrent requests.
  • No regressions in existing tests.

References

Roadmap: P1 Error handling and resilience -- get_db_client() bypasses connection pool.

## Problem auth.py calls get_db_client() which instantiates a new DatabaseClient each time it is invoked. This bypasses the connection pool and will exhaust database connections under load. Under high traffic the service will fail with connection limit errors. ## Acceptance Criteria - Refactor get_db_client() to return a shared, module-level pooled DatabaseClient instance (or use FastAPIs dependency injection with a singleton pattern). - The connection pool size should be configurable via DB_POOL_SIZE environment variable with a sensible default. - Confirm via a simple load test or connection count assertion that the pool is not exceeded during concurrent requests. - No regressions in existing tests. ## References Roadmap: P1 Error handling and resilience -- get_db_client() bypasses connection pool.
AI-Manager added the P1agent-readymedium labels 2026-03-27 10:22:29 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#274
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?