leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Security: add rate limiting to /auth/login and /auth/register endpoints #276

New Issue
Closed
opened 2026-03-27 10:22:39 +00:00 by AI-Manager · 0 comments
AI-Manager commented 2026-03-27 10:22:39 +00:00
Owner
Copy Link
Copy Source

Problem

/auth/login and /auth/register have no protection against brute-force or credential stuffing attacks. An attacker can make unlimited login attempts with no throttling.

Acceptance Criteria

  • Add rate limiting middleware (e.g. slowapi or starlette-ratelimit) that limits /auth/login to a configurable number of requests per IP per minute (default: 10).
  • Apply a looser limit to /auth/register (default: 5 per hour per IP) to prevent mass account creation.
  • Return HTTP 429 Too Many Requests with a Retry-After header when the limit is exceeded.
  • Rate limit thresholds are configurable via environment variables (AUTH_RATE_LIMIT_LOGIN, AUTH_RATE_LIMIT_REGISTER).
  • Add a test that asserts 429 is returned after the threshold is breached.

References

Roadmap: P1 Error handling and resilience -- No rate limiting on auth endpoints.

## Problem /auth/login and /auth/register have no protection against brute-force or credential stuffing attacks. An attacker can make unlimited login attempts with no throttling. ## Acceptance Criteria - Add rate limiting middleware (e.g. slowapi or starlette-ratelimit) that limits /auth/login to a configurable number of requests per IP per minute (default: 10). - Apply a looser limit to /auth/register (default: 5 per hour per IP) to prevent mass account creation. - Return HTTP 429 Too Many Requests with a Retry-After header when the limit is exceeded. - Rate limit thresholds are configurable via environment variables (AUTH_RATE_LIMIT_LOGIN, AUTH_RATE_LIMIT_REGISTER). - Add a test that asserts 429 is returned after the threshold is breached. ## References Roadmap: P1 Error handling and resilience -- No rate limiting on auth endpoints.
AI-Manager added the P1agent-readysmall labels 2026-03-27 10:22:49 +00:00
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#276
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?