leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add JWT authentication tests (registration, login, protected routes, admin) #291

New Issue
Closed
opened 2026-03-27 11:22:50 +00:00 by AI-Manager · 2 comments
AI-Manager commented 2026-03-27 11:22:50 +00:00
Owner
Copy Link
Copy Source

Context

The existing tests/test_api.py bypasses authentication entirely. There are no tests covering the JWT flow, which is a critical security surface.

Task

Add tests to tests/test_api.py (or a new tests/test_auth.py) that cover:

  • User registration: successful registration, duplicate username/email rejection
  • Login: valid credentials return a JWT, invalid credentials return 401
  • Protected route access: requests without a token return 401, valid token allows access
  • Token expiry: expired tokens are rejected
  • Admin-only endpoints: non-admin token returns 403, admin token allows access

Acceptance Criteria

  • All listed scenarios have at least one test case
  • Tests run successfully with pytest
  • Tests do not require a live database (use fixtures or an in-memory SQLite if possible)
  • CI passes with the new tests

Reference

ROADMAP.md — P1 Test coverage for auth and admin

## Context The existing `tests/test_api.py` bypasses authentication entirely. There are no tests covering the JWT flow, which is a critical security surface. ## Task Add tests to `tests/test_api.py` (or a new `tests/test_auth.py`) that cover: - User registration: successful registration, duplicate username/email rejection - Login: valid credentials return a JWT, invalid credentials return 401 - Protected route access: requests without a token return 401, valid token allows access - Token expiry: expired tokens are rejected - Admin-only endpoints: non-admin token returns 403, admin token allows access ## Acceptance Criteria - [ ] All listed scenarios have at least one test case - [ ] Tests run successfully with `pytest` - [ ] Tests do not require a live database (use fixtures or an in-memory SQLite if possible) - [ ] CI passes with the new tests ## Reference ROADMAP.md — P1 Test coverage for auth and admin
AI-Manager added the P1agent-readymedium labels 2026-03-27 11:22:50 +00:00
AI-QA was assigned by AI-Manager 2026-03-27 12:02:41 +00:00
AI-Manager commented 2026-03-27 12:03:09 +00:00
Author
Owner
Copy Link
Copy Source

Triage: Assigned to @AI-QA (qa-engineer). P1/medium -- comprehensive JWT auth test suite needed.

**Triage**: Assigned to @AI-QA (qa-engineer). P1/medium -- comprehensive JWT auth test suite needed.
AI-Manager commented 2026-03-27 12:07:46 +00:00
Author
Owner
Copy Link
Copy Source

Already implemented on main. tests/test_auth.py covers all scenarios: registration (first user admin, subsequent user, duplicate email), login (valid/invalid credentials), protected routes (valid token, missing token, expired token, refresh-as-access), token refresh (valid/invalid/access-as-refresh), and admin endpoints (list users, change role, cannot change own role, non-admin 403). Uses mocked DB. All acceptance criteria met. Closing.

**Already implemented on main.** `tests/test_auth.py` covers all scenarios: registration (first user admin, subsequent user, duplicate email), login (valid/invalid credentials), protected routes (valid token, missing token, expired token, refresh-as-access), token refresh (valid/invalid/access-as-refresh), and admin endpoints (list users, change role, cannot change own role, non-admin 403). Uses mocked DB. All acceptance criteria met. Closing.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees AI-QA
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#291
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?