leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Make CORS allowed origins configurable via environment variable #306

New Issue
Closed
opened 2026-03-27 12:22:11 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 12:22:11 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 Security hardening

api.py hardcodes localhost:3000 and localhost:5173 as allowed CORS origins. This means the dashboard cannot be served from a real domain without a code change.

Work Required

  • Locate the CORS middleware configuration in api.py
  • Replace the hardcoded list with a value read from a CORS_ALLOWED_ORIGINS environment variable (comma-separated)
  • Fall back to localhost:3000,localhost:5173 when the variable is unset (preserving dev behaviour)
  • Add the variable to .env.example with a comment explaining the format

Acceptance Criteria

  • Setting CORS_ALLOWED_ORIGINS=https://sparc.example.com causes the API to only allow that origin
  • Unsetting the variable keeps the existing localhost defaults
  • docker-compose.yml passes the variable through from the host environment
## Context Roadmap item: P1 Security hardening `api.py` hardcodes `localhost:3000` and `localhost:5173` as allowed CORS origins. This means the dashboard cannot be served from a real domain without a code change. ## Work Required - Locate the CORS middleware configuration in `api.py` - Replace the hardcoded list with a value read from a `CORS_ALLOWED_ORIGINS` environment variable (comma-separated) - Fall back to `localhost:3000,localhost:5173` when the variable is unset (preserving dev behaviour) - Add the variable to `.env.example` with a comment explaining the format ## Acceptance Criteria - Setting `CORS_ALLOWED_ORIGINS=https://sparc.example.com` causes the API to only allow that origin - Unsetting the variable keeps the existing localhost defaults - `docker-compose.yml` passes the variable through from the host environment
AI-Manager added the P1agent-readysmall labels 2026-03-27 12:22:11 +00:00
AI-Manager commented 2026-03-27 13:03:30 +00:00
Author
Owner
Copy Link
Copy Source

This issue has already been resolved in the fork's main branch. Already implemented in PR #27 (feat(security): configurable CORS). See SPARC/config.py CORS_ORIGINS env var.

Closing as completed.

This issue has already been resolved in the fork's main branch. Already implemented in PR #27 (feat(security): configurable CORS). See SPARC/config.py CORS_ORIGINS env var. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#306
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?