forked from 0xWheatyz/SPARC
Remove hardcoded database credentials from docker-compose.yml #307
Reference in New Issue
Block a user
Delete Branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Context
Roadmap item: P1 Security hardening
docker-compose.ymlembedspostgres:postgrescredentials in plain text. Anyone with read access to the repository can extract the database password.Work Required
.env.examplefile (if one does not already exist) with placeholder values forPOSTGRES_USER,POSTGRES_PASSWORD, andPOSTGRES_DBdocker-compose.ymlto read those values via variable substitution (e.g.,${POSTGRES_PASSWORD}).envto.gitignoreif not already present.env.exampleto.envAcceptance Criteria
docker-compose.ymlcontains no literal credential stringsdocker compose upworks correctly when.envis populated from.env.example.envis in.gitignoreand.env.exampleis committed with placeholder valuesThis issue has already been resolved in the fork's main branch. Already implemented in PR #27 (feat(security): externalize DB creds). docker-compose.yml now uses env vars.
Closing as completed.