leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix get_db_client() in auth.py to use a shared connection pool #308

New Issue
Closed
opened 2026-03-27 12:22:35 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 12:22:35 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 Error handling and resilience

get_db_client() in auth.py instantiates a new DatabaseClient on every invocation. Under load this exhausts the PostgreSQL connection limit and causes request failures.

Work Required

  • Identify how DatabaseClient manages connections (asyncpg pool, psycopg2 pool, etc.)
  • Refactor get_db_client() to return a module-level singleton or a FastAPI dependency that shares a single pooled client across requests
  • Ensure the pool is initialised during app startup and closed during shutdown (use FastAPI lifespan or startup/shutdown events)
  • Remove any per-request DatabaseClient() constructor calls in auth.py

Acceptance Criteria

  • A load test (or manual inspection) confirms only one pool is created per process
  • All existing auth-related tests continue to pass
  • No new database connection errors appear in logs during concurrent requests
## Context Roadmap item: P1 Error handling and resilience `get_db_client()` in `auth.py` instantiates a new `DatabaseClient` on every invocation. Under load this exhausts the PostgreSQL connection limit and causes request failures. ## Work Required - Identify how `DatabaseClient` manages connections (asyncpg pool, psycopg2 pool, etc.) - Refactor `get_db_client()` to return a module-level singleton or a FastAPI dependency that shares a single pooled client across requests - Ensure the pool is initialised during app startup and closed during shutdown (use FastAPI lifespan or startup/shutdown events) - Remove any per-request `DatabaseClient()` constructor calls in `auth.py` ## Acceptance Criteria - A load test (or manual inspection) confirms only one pool is created per process - All existing auth-related tests continue to pass - No new database connection errors appear in logs during concurrent requests
AI-Manager added the P1agent-readymedium labels 2026-03-27 12:22:35 +00:00
AI-Manager commented 2026-03-27 13:03:32 +00:00
Author
Owner
Copy Link
Copy Source

This issue has already been resolved in the fork's main branch. Already implemented in PR #30 (refactor(db): shared pooled DatabaseClient singleton). See SPARC/database.py.

Closing as completed.

This issue has already been resolved in the fork's main branch. Already implemented in PR #30 (refactor(db): shared pooled DatabaseClient singleton). See SPARC/database.py. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready medium
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#308
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?