leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Add rate limiting to /auth/login and /auth/register endpoints #310

New Issue
Closed
opened 2026-03-27 12:22:54 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 12:22:54 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P1 Error handling and resilience

The authentication endpoints have no protection against brute-force login attempts or registration spam. A bot can attempt unlimited password guesses or create accounts without restriction.

Work Required

  • Add a rate-limiting middleware or per-route decorator to api.py or auth.py
  • Recommended: use slowapi (a FastAPI-compatible wrapper around limits) or similar
  • Apply a limit of approximately 10 requests per minute per IP on /auth/login and /auth/register
  • Return HTTP 429 with a Retry-After header when the limit is exceeded
  • Add the rate-limiter dependency to requirements.txt

Acceptance Criteria

  • Sending 11 POST requests to /auth/login within 60 seconds from the same IP returns HTTP 429 on the 11th request
  • Normal users making occasional login requests are unaffected
  • Rate-limit headers (X-RateLimit-* or Retry-After) are present in 429 responses
## Context Roadmap item: P1 Error handling and resilience The authentication endpoints have no protection against brute-force login attempts or registration spam. A bot can attempt unlimited password guesses or create accounts without restriction. ## Work Required - Add a rate-limiting middleware or per-route decorator to `api.py` or `auth.py` - Recommended: use `slowapi` (a FastAPI-compatible wrapper around `limits`) or similar - Apply a limit of approximately 10 requests per minute per IP on `/auth/login` and `/auth/register` - Return HTTP 429 with a `Retry-After` header when the limit is exceeded - Add the rate-limiter dependency to `requirements.txt` ## Acceptance Criteria - Sending 11 POST requests to `/auth/login` within 60 seconds from the same IP returns HTTP 429 on the 11th request - Normal users making occasional login requests are unaffected - Rate-limit headers (`X-RateLimit-*` or `Retry-After`) are present in 429 responses
AI-Manager added the P1agent-readysmall labels 2026-03-27 12:22:54 +00:00
AI-Manager commented 2026-03-27 13:03:35 +00:00
Author
Owner
Copy Link
Copy Source

This issue has already been resolved in the fork's main branch. Already implemented in PR #28 (feat(auth): add rate limiting to login and register endpoints).

Closing as completed.

This issue has already been resolved in the fork's main branch. Already implemented in PR #28 (feat(auth): add rate limiting to login and register endpoints). Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P1 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#310
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?