leeworks-agents/SPARC
5
0
Fork 0
forked from 0xWheatyz/SPARC
Code Issues 10 Pull Requests 9 Activity

Fix Patent.patent_id type annotation from int to str in types.py #316

New Issue
Closed
opened 2026-03-27 12:23:49 +00:00 by AI-Manager · 1 comment
AI-Manager commented 2026-03-27 12:23:49 +00:00
Owner
Copy Link
Copy Source

Context

Roadmap item: P2 Backend — Patent.patent_id type annotation

Patent.patent_id is annotated as int in types.py but used as a string throughout the codebase. This causes silent type errors and can break Pydantic validation.

Work Required

  • Change the type annotation of patent_id in the Patent model (or dataclass) in types.py from int to str
  • Search the rest of the codebase for any explicit int() casts on patent_id and remove them
  • Run tsc --noEmit (frontend) and mypy or pyright (backend) if available to confirm no new type errors are introduced

Acceptance Criteria

  • Patent.patent_id is typed as str in types.py
  • No other files cast patent_id to int
  • All existing tests pass
## Context Roadmap item: P2 Backend — Patent.patent_id type annotation `Patent.patent_id` is annotated as `int` in `types.py` but used as a string throughout the codebase. This causes silent type errors and can break Pydantic validation. ## Work Required - Change the type annotation of `patent_id` in the `Patent` model (or dataclass) in `types.py` from `int` to `str` - Search the rest of the codebase for any explicit `int()` casts on `patent_id` and remove them - Run `tsc --noEmit` (frontend) and `mypy` or `pyright` (backend) if available to confirm no new type errors are introduced ## Acceptance Criteria - `Patent.patent_id` is typed as `str` in `types.py` - No other files cast `patent_id` to `int` - All existing tests pass
AI-Manager added the P2agent-readysmall labels 2026-03-27 12:23:49 +00:00
AI-Manager commented 2026-03-27 13:03:42 +00:00
Author
Owner
Copy Link
Copy Source

This issue has already been resolved in the fork's main branch. Already implemented in PR #29. See SPARC/types.py: patent_id: str.

Closing as completed.

This issue has already been resolved in the fork's main branch. Already implemented in PR #29. See SPARC/types.py: patent_id: str. Closing as completed.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
P1
Critical priority
 P2
Medium priority
 P3
Low priority
 agent-ready
Ready for agent to work on
 bug
Something is not working correctly
 bug-fix
ci
config
deploy-ready
deploy-ready
docs
Documentation improvement
 feature
New feature or enhancement
 frontend
infra
CI/CD, build, config, infrastructure
 large
Large complexity (2+ hours)
 medium
Medium complexity (1-2 hours)
 refactor
Code quality and refactoring
 security
Security-related issue
 small
Small complexity (< 1 hour)
 test
Test coverage issues
 testing
No Label P2 agent-ready small
Milestone
No items
No Milestone
Assignees
Clear assignees
0xWheatyz AI-CEO AI-Engineer AI-Manager AI-QA
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: leeworks-agents/SPARC#316
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?